From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Buffer size limitation in insdel.c Date: Thu, 23 Sep 2010 21:22:02 +0200 Message-ID: <837hicuuxx.fsf@gnu.org> References: <834odivv7v.fsf@gnu.org> <83r5gkvqpf.fsf@gnu.org> <83iq1wvep4.fsf@gnu.org> <83hbhgvblq.fsf@gnu.org> <83fwx0v97g.fsf@gnu.org> <83eickv7xo.fsf@gnu.org> <83d3s4uw4m.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1285269735 4109 80.91.229.12 (23 Sep 2010 19:22:15 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 23 Sep 2010 19:22:15 +0000 (UTC) Cc: emacs-devel@gnu.org To: Lars Magne Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 23 21:22:14 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OyrMy-0005kB-W6 for ged-emacs-devel@m.gmane.org; Thu, 23 Sep 2010 21:22:14 +0200 Original-Received: from localhost ([127.0.0.1]:40905 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OyrMw-0002Y3-37 for ged-emacs-devel@m.gmane.org; Thu, 23 Sep 2010 15:22:10 -0400 Original-Received: from [140.186.70.92] (port=44516 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OyrMp-0002X0-Lr for emacs-devel@gnu.org; Thu, 23 Sep 2010 15:22:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OyrMm-0004dZ-9a for emacs-devel@gnu.org; Thu, 23 Sep 2010 15:22:03 -0400 Original-Received: from mtaout21.012.net.il ([80.179.55.169]:60921) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OyrMm-0004dL-2l for emacs-devel@gnu.org; Thu, 23 Sep 2010 15:22:00 -0400 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0L9700F00SDLMB00@a-mtaout21.012.net.il> for emacs-devel@gnu.org; Thu, 23 Sep 2010 21:21:58 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([77.127.203.3]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L9700FLSSGLLL10@a-mtaout21.012.net.il>; Thu, 23 Sep 2010 21:21:58 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:130685 Archived-At: > From: Lars Magne Ingebrigtsen > Date: Thu, 23 Sep 2010 21:02:04 +0200 > > Eli Zaretskii writes: > > > Maybe try this on the files I modified today, to see how many problems > > I missed. (I tried this with GCC 4.2.4, but got zero matches from > > egrep, probably because the output format of -Wconversion is > > completely different. > > Let's see... > > Here's intervals.c: > > intervals.c:1938: warning: conversion to 'int' from 'long int' may alter its value > intervals.c:1961: warning: conversion to 'int' from 'long int' may alter its value > > Almost totally clean. Thanks, fixed. It was due to return value of a single function. > editfns.c, however: > > make -k 2>&1 | egrep "conversion.*'int'.*(Lisp_Ob|long)" > editfns.c:279: warning: conversion to 'int' from 'long int' may alter its value > editfns.c:281: warning: conversion to 'int' from 'long int' may alter its value > editfns.c:283: warning: conversion to 'int' from 'long int' may alter its value > editfns.c:825: warning: conversion to 'int' from 'long int' may alter its value > editfns.c:997: warning: conversion to 'int' from 'long int' may alter its value > editfns.c:1012: warning: conversion to 'int' from 'long int' may alter its value > editfns.c:1533: warning: conversion to 'int' from 'Lisp_Object' may alter its value > editfns.c:1683: warning: conversion to 'int' from 'long int' may alter its value > editfns.c:1807: warning: conversion to 'int' from 'Lisp_Object' may alter its value > editfns.c:1808: warning: conversion to 'int' from 'Lisp_Object' may alter its value Only the first 3 are related to buffer and string positions (again, return value of a single function); I fixed them. The rest are unrelated: they are about SPECPDL_INDEX and time values. Thanks.