From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: 'struct window' cleanup #2 Date: Tue, 26 Jun 2012 18:37:42 +0300 Message-ID: <837guu9j95.fsf@gnu.org> References: <4FE827B6.6020306@yandex.ru> <4FE89369.2000708@gmx.at> <4FE896A9.3090002@yandex.ru> <4FE9643C.1090201@gmx.at> <4FE97BAC.5060501@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: dough.gmane.org 1340725065 4051 80.91.229.3 (26 Jun 2012 15:37:45 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 26 Jun 2012 15:37:45 +0000 (UTC) Cc: rudalics@gmx.at, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Dmitry Antipov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 26 17:37:43 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SjXpn-0004bD-Dq for ged-emacs-devel@m.gmane.org; Tue, 26 Jun 2012 17:37:43 +0200 Original-Received: from localhost ([::1]:37418 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SjXpn-00037C-CH for ged-emacs-devel@m.gmane.org; Tue, 26 Jun 2012 11:37:43 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:33577) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SjXpk-00036r-UX for emacs-devel@gnu.org; Tue, 26 Jun 2012 11:37:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SjXpc-0005Zt-KR for emacs-devel@gnu.org; Tue, 26 Jun 2012 11:37:40 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:48349) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SjXpc-0005Zh-CO for emacs-devel@gnu.org; Tue, 26 Jun 2012 11:37:32 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0M6800900DVS1F00@a-mtaout22.012.net.il> for emacs-devel@gnu.org; Tue, 26 Jun 2012 18:37:31 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.210.75]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M68008EVE2IF8B0@a-mtaout22.012.net.il>; Tue, 26 Jun 2012 18:37:31 +0300 (IDT) In-reply-to: <4FE97BAC.5060501@yandex.ru> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.172 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:151188 Archived-At: > Date: Tue, 26 Jun 2012 13:06:52 +0400 > From: Dmitry Antipov > Cc: Stefan Monnier , > Emacs development discussions > > On 06/26/2012 11:26 AM, martin rudalics wrote: > > > Indeed. Looks like a hack to detect whether the window still shows the > > same buffer. Anyway, window_end_pos and window_end_vpos are the more > > promising candidates (if Eli agrees). Can you see whether the part > > > > /* When splitting windows or for new windows, it happens that > > redisplay is called with a nil window_end_vpos or one being > > larger than the window. This should really be fixed in > > window.c. I don't have this on my list, now, so we do > > approximately the same as the old redisplay code. --gerd. */ > > && INTEGERP (w->window_end_vpos) > > > > in xdisp.c still makes sense? IIUC window_end_vpos is always an > > integer. > > Hmmm... I'll try, although xdisp.c looks like a nightmare > and I haven't yet tried to understand how it works :-). I'm hacking xdisp.c intensively for 3 years, and I still get surprised from time to time.