all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 12036@debbugs.gnu.org
Subject: bug#12036: 24.1.50; xvectype and xpr broken by change in PVEC_TYPE_MASK when	macro	information not available
Date: Fri, 27 Jul 2012 12:40:07 +0300	[thread overview]
Message-ID: <837gtpk0eg.fsf@gnu.org> (raw)
In-Reply-To: <501233B0.2010907@cs.ucla.edu>

> Date: Thu, 26 Jul 2012 23:22:40 -0700
> From: Paul Eggert <eggert@cs.ucla.edu>
> CC: 12036@debbugs.gnu.org
> 
> On 07/26/2012 01:10 PM, Eli Zaretskii wrote:
> > Anyway, with tricky macros such as PUBLISH_TO_GDB, I'd think that
> > going back to using variables whose type is the enum would be better,
> 
> Yes, that's right.  Unfortunately this can't be encapsulated as nicely
> as PUBLISH_TO_GDB can, so I reverted the PUBLISH_TO_GDB business
> and went back to the old way of making enums visible, in
> trunk bzr 109224.  Please give it a try.

Thanks, it seems to work now, at least in a few simple tests I ran
here.  However, there's still a small nuisance:

  (gdb) break decode_any_window
  Breakpoint 3 at 0x11de2a8: file window.c, line 149.
  (gdb) r -Q
  Starting program: D:\gnu\bzr\emacs\trunk\src/./oo/i386/emacs.exe -Q
  [New Thread 1452.0x15d4]

  Breakpoint 3, decode_any_window (window=54896461) at window.c:149
  149       if (NILP (window))
  (gdb) n
  152       CHECK_WINDOW (window);
  (gdb) p window
  $1 = 54896461
  (gdb) xtype
  Lisp_Vectorlike
  262144          <<<<<<<<<<<<<<<<<<<<<<

In Emacs 24.1, it does better:

  (gdb) p window
  $1 = 53340677
  (gdb) xtype
  Lisp_Vectorlike
  PVEC_WINDOW

I'm not sure if it will be better to go back to 24.1 behavior and
display PVEC_WINDOW, or change .gdbinit to say something more explicit
and human-readable here, such as "window" (and similarly for other
vector-like types).





  reply	other threads:[~2012-07-27  9:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-23 18:13 bug#12036: 24.1.50; xvectype and xpr broken by change in PVEC_TYPE_MASK when macro information not available Eli Zaretskii
2012-07-26  9:14 ` Paul Eggert
2012-07-26 16:56   ` Eli Zaretskii
2012-07-26 18:03     ` Eli Zaretskii
2012-07-26 18:46       ` Paul Eggert
2012-07-26 20:10         ` Eli Zaretskii
2012-07-27  6:22           ` Paul Eggert
2012-07-27  9:40             ` Eli Zaretskii [this message]
2012-07-27 20:51               ` Paul Eggert
2012-07-28  7:30                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=837gtpk0eg.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=12036@debbugs.gnu.org \
    --cc=eggert@cs.ucla.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.