all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Lars Magne Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Re: image-size
Date: Thu, 20 Jun 2013 19:01:57 +0300	[thread overview]
Message-ID: <837ghopy8a.fsf@gnu.org> (raw)
In-Reply-To: <m3ip19drnf.fsf@stories.gnus.org>

> From: Lars Magne Ingebrigtsen <larsi@gnus.org>
> Date: Thu, 20 Jun 2013 12:04:52 +0200
> 
> If I remember correctly from previous discussions, if you call
> `image-size', Emacs will go through all the normal stuff it does before
> displaying it, including pushing it to the X server, and then ask it how
> big it was.

I don't think so.  Where do you see X calls that "push the image to
the X server"?

I see no display stuff in image.c, only loading of the image and
storing all kinds of metrics of it in an object.  Display happens
later.

> (I'm having a bit of a problem following the logic of lookup_image,
> but it looks complicated.  :-)

The only relevant part is this:

      img->load_failed_p = ! img->type->load (f, img);

This invokes the 'load' method of the relevant image type.

> 2) If so, would someone mind very much if I alter `image-size' to do a
> "fast path" iff a) we're asking for the pixel size, and b) we have
> imagemagick compiled it?  If those two things are true, I could add some
> code to just ask imagemagick how big the image is without involving the
> display engine at all, and things would be a lot faster, I imagine.

I see no reason for relying on imagemagick.  You will see in each
'load' method a short fragment of code that finds the image size.  If
you want a "fast path", just add another flag argument to the 'load'
method that tells it to return as soon as it computed the size, and
that's it.

Restricting this to Emacs built with imagemagick would be a
regrettable limitation, IMO.



  parent reply	other threads:[~2013-06-20 16:01 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-20 10:04 image-size Lars Magne Ingebrigtsen
2013-06-20 12:18 ` image-size Lars Magne Ingebrigtsen
2013-06-20 16:52   ` image-size Eli Zaretskii
2013-06-20 16:01 ` Eli Zaretskii [this message]
2013-06-20 16:50   ` image-size Lars Magne Ingebrigtsen
2013-06-20 16:55     ` image-size Lars Magne Ingebrigtsen
2013-06-20 17:16       ` image-size Eli Zaretskii
2013-06-20 17:54         ` image-size Lars Magne Ingebrigtsen
2013-06-20 18:15           ` image-size Eli Zaretskii
2013-06-20 18:31             ` image-size Eli Zaretskii
2013-06-20 18:46               ` image-size Lars Magne Ingebrigtsen
2013-06-20 19:11                 ` image-size Eli Zaretskii
2013-06-20 19:18                   ` image-size Lars Magne Ingebrigtsen
2013-06-20 19:37                     ` image-size Eli Zaretskii
2013-06-20 19:52                       ` image-size David Engster
2013-06-20 20:50                         ` image-size Eli Zaretskii
2013-06-20 19:34                   ` image-size Lars Magne Ingebrigtsen
2013-06-20 19:42                     ` image-size Eli Zaretskii
2013-06-20 19:52                       ` image-size Lars Magne Ingebrigtsen
2013-06-20 20:53                         ` image-size Eli Zaretskii
2013-06-20 20:57                           ` image-size Lars Magne Ingebrigtsen
2013-06-20 21:06                             ` image-size Lars Magne Ingebrigtsen
2013-06-21  6:12                               ` image-size Eli Zaretskii
2013-06-20 21:42                             ` image-size Jan Djärv
2013-06-21  0:46                               ` image-size YAMAMOTO Mitsuharu
2013-06-21  6:27                                 ` image-size Lars Magne Ingebrigtsen
2013-06-26  8:25                                   ` image-size YAMAMOTO Mitsuharu
2013-06-26 10:39                                     ` image-size YAMAMOTO Mitsuharu
2013-06-26 12:04                                     ` image-size Lars Magne Ingebrigtsen
2013-06-27  0:46                                       ` image-size Lars Magne Ingebrigtsen
2013-06-27  2:49                                         ` image-size Stefan Monnier
2013-06-28  2:46                                       ` image-size YAMAMOTO Mitsuharu
2013-06-28  3:12                                         ` image-size Juanma Barranquero
2013-06-28  3:45                                           ` image-size YAMAMOTO Mitsuharu
2013-06-21  6:15                               ` image-size Eli Zaretskii
2013-06-21  7:34                                 ` image-size Jan Djärv
2013-06-21  8:27                                   ` image-size Eli Zaretskii
2013-06-21  9:03                                     ` image-size Jan Djärv
2013-06-21  9:07                                       ` image-size Lars Magne Ingebrigtsen
2013-06-21  9:58                                         ` image-size Eli Zaretskii
2013-06-21  9:57                                       ` image-size Eli Zaretskii
2013-06-21  6:13                             ` image-size Eli Zaretskii
2013-06-21 15:54                               ` image-size Willem Rein Oudshoorn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=837ghopy8a.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.