From: Eli Zaretskii <eliz@gnu.org>
To: claudio.bley@gmail.com (Claudio Bley)
Cc: emacs-devel@gnu.org
Subject: Re: build fails with new MinGW wchar.h
Date: Wed, 20 Nov 2013 20:15:41 +0200 [thread overview]
Message-ID: <837gc3ey7m.fsf@gnu.org> (raw)
In-Reply-To: <87d2lvv8mh.wl%claudio.bley@gmail.com>
> From: claudio.bley@gmail.com (Claudio Bley)
> Date: Wed, 20 Nov 2013 08:24:06 +0100
>
> c:\mingw\include\wchar.h:816:32: error: conflicting types for '_wstat64i32'
> __CRT_MAYBE_INLINE int __cdecl _wstat64i32(const wchar_t *fname, struct _stat64i32 *_stat)
> ^
> c:\mingw\include\wchar.h:814:29: note: previous declaration of '_wstat64i32' was here
> int __cdecl __MINGW_NOTHROW _wstat64i32 (const wchar_t*, struct _stat64i32*);
> ^
> c:\mingw\include\wchar.h: In function '_wstat64i32':
> c:\mingw\include\wchar.h:818:20: error: storage size of 'st' isn't known
> struct _stat64 st;
> ^
> c:\mingw\include\wchar.h:821:31: error: invalid application of 'sizeof' to incomplete type 'struct _stat64i32'
> memset(_stat, 0, sizeof(struct _stat64i32));
> ^
> c:\mingw\include\wchar.h:824:10: error: dereferencing pointer to incomplete type
> _stat->st_dev = st.st_dev;
> ^
> c:\mingw\include\wchar.h:825:10: error: dereferencing pointer to incomplete type
The reason is that MinGW Runtime 4.x added a few more variants of
'struct stat', which nt/inc/sys/stat.h does not have.
> This patch fixes it for me:
Thanks.
> diff --git a/nt/inc/sys/stat.h b/nt/inc/sys/stat.h
> index f1d8341..88352b1 100644
> --- a/nt/inc/sys/stat.h
> +++ b/nt/inc/sys/stat.h
> @@ -23,6 +23,8 @@ along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>. */
>
> #ifdef __MINGW32__
> # include <_mingw.h>
> +# define _STAT_DEFINED
Why did you need this part? nt/inc/sys/stat.h already defines
_STAT_DEFINED, why do we need a second definition.
> +# define _WSTAT_DEFINED
We cannot define this symbol without also declaring the structures
guarded by it in the MinGW headers. We should add them, and then
define _WSTAT_DEFINED.
next prev parent reply other threads:[~2013-11-20 18:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-20 7:24 build fails with new MinGW wchar.h Claudio Bley
2013-11-20 18:15 ` Eli Zaretskii [this message]
2013-11-21 7:36 ` Claudio Bley
2013-11-21 17:36 ` Eli Zaretskii
2014-01-11 14:50 ` Eli Zaretskii
2014-01-14 10:28 ` Claudio Bley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837gc3ey7m.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=claudio.bley@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.