From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [elpa] 02/04: company-clang: handle multibyte chars between bol and point Date: Wed, 19 Mar 2014 18:40:25 +0200 Message-ID: <837g7q9m6e.fsf@gnu.org> References: <20140319033013.17542.14344@vcs.savannah.gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1395247227 10286 80.91.229.3 (19 Mar 2014 16:40:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 19 Mar 2014 16:40:27 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 19 17:40:35 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WQJXd-0007QF-N1 for ged-emacs-devel@m.gmane.org; Wed, 19 Mar 2014 17:40:33 +0100 Original-Received: from localhost ([::1]:42641 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQJXd-00019W-Ag for ged-emacs-devel@m.gmane.org; Wed, 19 Mar 2014 12:40:33 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59501) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQJXT-0000mu-B6 for emacs-devel@gnu.org; Wed, 19 Mar 2014 12:40:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQJXM-00057d-1s for emacs-devel@gnu.org; Wed, 19 Mar 2014 12:40:23 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:45149) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQJXL-00057U-R7 for emacs-devel@gnu.org; Wed, 19 Mar 2014 12:40:16 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0N2O00500ZKX1X00@a-mtaout22.012.net.il> for emacs-devel@gnu.org; Wed, 19 Mar 2014 18:40:14 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N2O005V7ZN10500@a-mtaout22.012.net.il>; Wed, 19 Mar 2014 18:40:14 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.172 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:170551 Archived-At: > From: Stefan > Date: Wed, 19 Mar 2014 09:15:27 -0400 > > > - (- (point) (line-beginning-position) -1)))) > > + (1+ (string-bytes (buffer-substring > > + (line-beginning-position) > > + (point))))))) > > Instead of buffer-subtring composed with string-bytes, you could use > position-bytes. You might also like to add a comment like "Hack attack: > assume the file's encoding is the same as Emacs's internal encoding". Why assume such a thing? It's bound to break some day, for some user. I would suggest encoding the buffer substring using buffer-file-coding-system, and then using (length string) on the result (which will be a unibyte string, so there's no difference between byte and character counts). Then this code will be portable, I think.