From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#17510: 24.3.91; Problem with `emacs --daemon' in cygw32 build Date: Mon, 19 May 2014 19:46:56 +0300 Message-ID: <837g5hd8cf.fsf@gnu.org> References: <53764FD9.8090600@cornell.edu> <53766FBC.1000601@cornell.edu> <5377F335.2080609@cornell.edu> <831tvremfz.fsf@gnu.org> <5378C404.8050405@cornell.edu> <83wqdjceah.fsf@gnu.org> <53790BAB.3020909@cornell.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1400518106 5120 80.91.229.3 (19 May 2014 16:48:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 19 May 2014 16:48:26 +0000 (UTC) Cc: 17510@debbugs.gnu.org, dmantipov@yandex.ru To: Ken Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 19 18:48:18 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WmQjZ-0004NQ-7e for geb-bug-gnu-emacs@m.gmane.org; Mon, 19 May 2014 18:48:17 +0200 Original-Received: from localhost ([::1]:49242 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmQjY-0006lf-LU for geb-bug-gnu-emacs@m.gmane.org; Mon, 19 May 2014 12:48:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60659) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmQjR-0006lJ-53 for bug-gnu-emacs@gnu.org; Mon, 19 May 2014 12:48:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WmQjK-0007BN-PN for bug-gnu-emacs@gnu.org; Mon, 19 May 2014 12:48:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54443) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WmQjK-0007BE-Mo for bug-gnu-emacs@gnu.org; Mon, 19 May 2014 12:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WmQjK-0001CR-7E for bug-gnu-emacs@gnu.org; Mon, 19 May 2014 12:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 May 2014 16:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17510 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17510-submit@debbugs.gnu.org id=B17510.14005180294533 (code B ref 17510); Mon, 19 May 2014 16:48:02 +0000 Original-Received: (at 17510) by debbugs.gnu.org; 19 May 2014 16:47:09 +0000 Original-Received: from localhost ([127.0.0.1]:53320 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WmQiR-0001B2-HC for submit@debbugs.gnu.org; Mon, 19 May 2014 12:47:07 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:40645) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WmQiO-0001AT-3T for 17510@debbugs.gnu.org; Mon, 19 May 2014 12:47:05 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0N5T00800YKUBX00@a-mtaout22.012.net.il> for 17510@debbugs.gnu.org; Mon, 19 May 2014 19:46:57 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N5T007NZYM3ZD60@a-mtaout22.012.net.il>; Mon, 19 May 2014 19:46:51 +0300 (IDT) In-reply-to: <53790BAB.3020909@cornell.edu> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:89246 Archived-At: > Date: Sun, 18 May 2014 15:36:11 -0400 > From: Ken Brown > CC: 17510@debbugs.gnu.org, dmantipov@yandex.ru > > > If the Cygwin-w32 build wants more (or less) than one display_info > > object, then that part _is_ specific to Cygwin, because the native > > Windows build has only one such object that is never deleted. > > > >> Can you reproduce it in the Windows build? > > > > The native Windows build doesn't support --daemon, so no, I can't. > > > >> I *think* what must be happening in the recipe that I gave for this bug > >> is that every time a client frame is closed, x_delete_display is called. > >> Before Dmitry's change, this would actually delete something from a > >> list. Now it doesn't, and the server gets messed up and ultimately dies > >> on the third attempt to create a client frame. > > > > See above: try restoring that code for Cygwin only. > > > >> Unless there's an obvious fix for this, it seems to me that we're far > >> enough into the pretest that we should just revert to the old code, at > >> least for emacs-24. > > > > That would revert a useful cleanup, which I'm not sure is a good idea > > at this point. > > How does this look? I guess it's OK for the branch, thanks. But it strikes me that simply replacing the car of dpyinfo->name_list_element by something like "!!!DELETED DISPLAY!!!", or even just an empty string, would serve the same purpose, and save us the nuisance of an additional list in cygw32_display_name_list. After all, all you need is to mark a display deleted without actually deleting it, right? IOW, the main problem is in x_delete_display, and all the rest is just the overhead you needed to fix that, correct?