From: Eli Zaretskii <eliz@gnu.org>
To: Ken Brown <kbrown@cornell.edu>
Cc: 17510@debbugs.gnu.org, dmantipov@yandex.ru
Subject: bug#17510: 24.3.91; Problem with `emacs --daemon' in cygw32 build
Date: Mon, 19 May 2014 19:46:56 +0300 [thread overview]
Message-ID: <837g5hd8cf.fsf@gnu.org> (raw)
In-Reply-To: <53790BAB.3020909@cornell.edu>
> Date: Sun, 18 May 2014 15:36:11 -0400
> From: Ken Brown <kbrown@cornell.edu>
> CC: 17510@debbugs.gnu.org, dmantipov@yandex.ru
>
> > If the Cygwin-w32 build wants more (or less) than one display_info
> > object, then that part _is_ specific to Cygwin, because the native
> > Windows build has only one such object that is never deleted.
> >
> >> Can you reproduce it in the Windows build?
> >
> > The native Windows build doesn't support --daemon, so no, I can't.
> >
> >> I *think* what must be happening in the recipe that I gave for this bug
> >> is that every time a client frame is closed, x_delete_display is called.
> >> Before Dmitry's change, this would actually delete something from a
> >> list. Now it doesn't, and the server gets messed up and ultimately dies
> >> on the third attempt to create a client frame.
> >
> > See above: try restoring that code for Cygwin only.
> >
> >> Unless there's an obvious fix for this, it seems to me that we're far
> >> enough into the pretest that we should just revert to the old code, at
> >> least for emacs-24.
> >
> > That would revert a useful cleanup, which I'm not sure is a good idea
> > at this point.
>
> How does this look?
I guess it's OK for the branch, thanks. But it strikes me that simply
replacing the car of dpyinfo->name_list_element by something like
"!!!DELETED DISPLAY!!!", or even just an empty string, would serve the
same purpose, and save us the nuisance of an additional list in
cygw32_display_name_list. After all, all you need is to mark a
display deleted without actually deleting it, right? IOW, the main
problem is in x_delete_display, and all the rest is just the overhead
you needed to fix that, correct?
next prev parent reply other threads:[~2014-05-19 16:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 17:50 bug#17510: 24.3.91; Problem with `emacs --daemon' in cygw32 build Ken Brown
2014-05-16 20:06 ` Ken Brown
2014-05-17 23:39 ` Ken Brown
2014-05-18 4:32 ` Eli Zaretskii
2014-05-18 14:30 ` Ken Brown
2014-05-18 15:11 ` Eli Zaretskii
2014-05-18 19:36 ` Ken Brown
2014-05-19 12:03 ` Ken Brown
2014-05-19 16:46 ` Eli Zaretskii [this message]
2014-05-19 17:31 ` Eli Zaretskii
2014-05-19 19:25 ` Ken Brown
2014-05-24 12:38 ` Ken Brown
2014-05-24 12:59 ` Eli Zaretskii
2014-05-24 18:14 ` Ken Brown
2014-05-24 22:18 ` Ken Brown
2014-05-24 19:28 ` Daniel Colascione
2014-05-24 22:18 ` Ken Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837g5hd8cf.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=17510@debbugs.gnu.org \
--cc=dmantipov@yandex.ru \
--cc=kbrown@cornell.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.