From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel@gnu.org
Subject: [Emacs-diffs] trunk r117941: Default to stack objects on non-GNU/Linux, non-DOS_NT platforms.
Date: Thu, 25 Sep 2014 11:15:02 +0300 [thread overview]
Message-ID: <837g0sw1yx.fsf@gnu.org> (raw)
I don't understand this commit.
. It was done in complete silence, without prior discussions wrt
whether to make this the default. (Yes, I suggested that, but no
one replied, and we never discussed it.)
. It arbitrarily excludes the native MS-Windows builds from this
feature, for no good reasons: the 64-bit Windows build has no
problems with it, and the problem discovered in the 32-bit build
has a simple solution. If you (Paul) didn't want to implement
that solution yourself, you could have asked _before_ turning
this on.
In general, every feature that exists only on some platforms is a
Bad Thing, as it introduces maintenance problems and in particular
makes people who work on different platforms unable to usefully
compare what they see and solve problems reported by others.
. It does include the 32-bit Cygwin-w32 build which could
potentially be affected by the same problem as the native Windows
32-bit builds.
In sum, I don't understand these sneaky practices, and I wish they'd
stopped. How many times do you have to be told to revert your commits
before you understand that this is not how we do things around here?
next reply other threads:[~2014-09-25 8:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 8:15 Eli Zaretskii [this message]
2014-09-25 9:51 ` [Emacs-diffs] trunk r117941: Default to stack objects on non-GNU/Linux, non-DOS_NT platforms Dmitry Antipov
2014-09-25 10:14 ` Eli Zaretskii
2014-09-25 12:52 ` Stefan Monnier
2014-09-25 16:12 ` Dmitry Antipov
2014-09-25 18:12 ` Stefan Monnier
2014-09-25 19:08 ` Paul Eggert
2014-09-25 9:52 ` Eli Zaretskii
2014-09-25 16:06 ` Paul Eggert
2014-09-25 16:48 ` Eli Zaretskii
2014-09-25 18:46 ` Paul Eggert
2014-09-25 19:16 ` Eli Zaretskii
2014-09-25 20:56 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837g0sw1yx.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.