From: Eli Zaretskii <eliz@gnu.org>
To: Kenichi Handa <handa@gnu.org>
Cc: dmantipov@yandex.ru, maden.ldm@gmail.com, 18610@debbugs.gnu.org
Subject: bug#18610: 24.4.50; Specific file causing emacs to segfault upon opening
Date: Fri, 03 Oct 2014 15:39:05 +0300 [thread overview]
Message-ID: <837g0hiaza.fsf@gnu.org> (raw)
In-Reply-To: <83a95dibtt.fsf@gnu.org>
> Date: Fri, 03 Oct 2014 15:20:46 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 18610@debbugs.gnu.org, maden.ldm@gmail.com
>
> --- src/coding.c 2014-08-06 17:37:22 +0000
> +++ src/coding.c 2014-10-03 12:09:28 +0000
> @@ -6559,7 +6559,8 @@ detect_coding (struct coding_system *cod
> && ! inhibit_ied
> && ! detect_info.checked)
> {
> - if (detect_coding_iso_2022 (coding, &detect_info))
> + if (detect_coding_iso_2022 (coding, &detect_info)
> + && detect_info.found != 0)
> {
> /* We have scanned the whole data. */
> if (! (detect_info.rejected & CATEGORY_MASK_ISO_7_ELSE))
>
>
Alternatively, perhaps detect_coding_iso_2022 shouldn't return 1 if
the 'found' member is zero.
Btw, there's one more issue that bothers me. In ONE_MORE_BYTE we have
this:
c = *src++; \
if (multibytep && (c & 0x80)) \
{ \
if ((c & 0xFE) == 0xC0) \
c = ((c & 1) << 6) | *src++; \
else \
{ \
src--; \
c = - string_char (src, &src, NULL); \
record_conversion_result \
(coding, CODING_RESULT_INVALID_SRC); \
} \
} \
If 'src' is a signed type, the first line above assigns a negative
value to c for values beyond 127. But, as seen from the code after
that, negative values have special meaning. So I wonder if we need to
make sure the first line above always assigns non-negative values to
c.
Same problem exists in TWO_MORE_BYTES.
next prev parent reply other threads:[~2014-10-03 12:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-02 14:50 bug#18610: 24.4.50; Specific file causing emacs to segfault upon opening maden.ldm
2014-10-02 15:40 ` Nicolas Richard
2014-10-03 8:14 ` Eli Zaretskii
2014-10-03 11:22 ` Dmitry Antipov
2014-10-03 12:20 ` Eli Zaretskii
2014-10-03 12:39 ` Eli Zaretskii [this message]
2014-10-03 15:16 ` Andreas Schwab
2014-10-03 15:32 ` Eli Zaretskii
2014-10-03 16:02 ` Andreas Schwab
2014-10-03 16:35 ` Eli Zaretskii
2014-10-03 16:40 ` Andreas Schwab
2014-10-03 16:57 ` Eli Zaretskii
2014-10-05 8:59 ` K. Handa
2014-10-05 16:09 ` Eli Zaretskii
2014-10-06 14:00 ` K. Handa
2014-10-06 15:20 ` Eli Zaretskii
2014-10-07 12:34 ` K. Handa
2014-10-07 13:20 ` Ivan Shmakov
2014-10-07 14:33 ` Eli Zaretskii
2014-10-07 15:10 ` Ivan Shmakov
2014-10-07 15:19 ` Eli Zaretskii
2014-10-08 7:33 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837g0hiaza.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=18610@debbugs.gnu.org \
--cc=dmantipov@yandex.ru \
--cc=handa@gnu.org \
--cc=maden.ldm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.