all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: esperanto@cumego.com, emacs-devel@gnu.org
Subject: Re: [PATCH] Fix tramp test
Date: Sun, 22 Feb 2015 18:00:44 +0200	[thread overview]
Message-ID: <837fvac4wj.fsf@gnu.org> (raw)
In-Reply-To: <871tlighi6.fsf@gmx.de>

> From: Michael Albinus <michael.albinus@gmx.de>
> Date: Sun, 22 Feb 2015 15:14:57 +0100
> Cc: emacs-devel@gnu.org
> 
> > A tiny patch for a test that fails in non English systems. OS output summary is
> > language dependent and for example in Polish it displays "razem 1234" instead of
> > "total 1234".
> >
> > Please let me know if it can't be applied for some reason.
> >
> > diff --git a/test/automated/tramp-tests.el b/test/automated/tramp-tests.el
> > index 2c4610c..e60a13f 100644
> > --- a/test/automated/tramp-tests.el
> > +++ b/test/automated/tramp-tests.el
> > @@ -955,7 +955,7 @@ This tests also `file-directory-p' and `file-accessible-directory-p'."
> >  	     (looking-at-p
> >  	      (concat
> >  	       ;; There might be a summary line.
> > -	       "\\(total.+[[:digit:]]+\n\\)?"
> > +	       "\\([[:alpha:]].+[[:digit:]]+\n\\)?"
> 
> Better might be "\\([[:alpha:]]+[[:blank:]]+[[:digit:]]+\n\\)?"

IMO, [:alpha:] is too indiscreet: it will match almost anything,
except in pure ASCII range.  Including some error message, for
example.

So I think it would be much better to keep the literal "total", and
instead set LC_MESSAGES=en_US.UTF-8, or something similar.



  reply	other threads:[~2015-02-22 16:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-22 12:25 [PATCH] Fix tramp test Przemysław Wojnowski
2015-02-22 14:14 ` Michael Albinus
2015-02-22 16:00   ` Eli Zaretskii [this message]
2015-02-22 16:25     ` Michael Albinus
2015-02-22 17:10       ` Eli Zaretskii
2015-02-22 19:01         ` Michael Albinus
2015-02-22 19:33           ` Przemysław Wojnowski
2015-02-22 20:53           ` Andreas Schwab
2015-02-22 21:46             ` Michael Albinus
2015-02-22 17:07     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=837fvac4wj.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=esperanto@cumego.com \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.