From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#21432: 25.0.50; file-notify-rm-watch (inotify) errors if watched dir is deleted Date: Mon, 14 Sep 2015 16:22:38 +0300 Message-ID: <837fnt9lup.fsf@gnu.org> References: <87k2s15sfd.fsf@gnu.org> <83oahc7vxr.fsf@gnu.org> <87lhcgvr1t.fsf@gmx.de> <87r3m4hrfq.fsf@gmx.de> <83fv2jbrkm.fsf@gnu.org> <87zj0rh5lb.fsf@gmx.de> <87h9myt96l.fsf@gmx.de> <87zj0pild7.fsf@gnu.org> <83oah5a35p.fsf@gnu.org> <87vbbdih3w.fsf@gnu.org> <87r3m1igdf.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1442237011 20652 80.91.229.3 (14 Sep 2015 13:23:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 14 Sep 2015 13:23:31 +0000 (UTC) Cc: michael.albinus@gmx.de, 21432@debbugs.gnu.org To: Tassilo Horn Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 14 15:23:20 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZbTj2-0007GU-RM for geb-bug-gnu-emacs@m.gmane.org; Mon, 14 Sep 2015 15:23:17 +0200 Original-Received: from localhost ([::1]:40689 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbTj2-0003tM-4f for geb-bug-gnu-emacs@m.gmane.org; Mon, 14 Sep 2015 09:23:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41887) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbTis-0003nB-RD for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2015 09:23:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZbTio-0007Uj-UG for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2015 09:23:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39308) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbTio-0007Uf-R5 for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2015 09:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZbTio-00066H-IT for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2015 09:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Sep 2015 13:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21432 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21432-submit@debbugs.gnu.org id=B21432.144223696323406 (code B ref 21432); Mon, 14 Sep 2015 13:23:02 +0000 Original-Received: (at 21432) by debbugs.gnu.org; 14 Sep 2015 13:22:43 +0000 Original-Received: from localhost ([127.0.0.1]:59748 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZbTiV-00065S-6e for submit@debbugs.gnu.org; Mon, 14 Sep 2015 09:22:43 -0400 Original-Received: from mtaout29.012.net.il ([80.179.55.185]:34580) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZbTiS-00065I-MN for 21432@debbugs.gnu.org; Mon, 14 Sep 2015 09:22:42 -0400 Original-Received: from conversion-daemon.mtaout29.012.net.il by mtaout29.012.net.il (HyperSendmail v2007.08) id <0NUO0080051VY000@mtaout29.012.net.il> for 21432@debbugs.gnu.org; Mon, 14 Sep 2015 16:23:08 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by mtaout29.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NUO0086H56KHZ10@mtaout29.012.net.il>; Mon, 14 Sep 2015 16:23:08 +0300 (IDT) In-reply-to: <87r3m1igdf.fsf@gnu.org> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:106524 Archived-At: > From: Tassilo Horn > Cc: michael.albinus@gmx.de, 21432@debbugs.gnu.org > Date: Mon, 14 Sep 2015 09:56:12 +0200 > > >> AFAIR, filenotify.el watches the parent directory of the > >> file/directory you asked it to watch. So to see the invalid-p method > >> in action you need to remove the parent, not the directory itself. > > > > Ah, I see. I'll adapt the tests accordingly. > > Done, however the descriptors still don't become invalid when deleting > the parent directory of the watched file or directory. I guess, that's > a problem in the inotify and TRAMP implementations then. No, I think it's a problem with our mental model of what happens. The file notifications use the Emacs event loop, and Emacs won't check for events until it's idle. So calling file-notify-valid-p as part of the test ends up doing that _before_ the directory deletion notification is read by Emacs and invalidates the watch. I actually see the message saying the watch is valid before the notification comes in and its message is inserted into *Messages*. The following simple test case works with w32notify: (setq mydir "/tmp/x") (make-directory mydir t) (setq myfile "/tmp/x/y") (write-region "foo\n" nil myfile) (setq w (w32notify-add-watch mydir '(file-name attributes size last-write-time) (lambda (event) (message "%s" event)))) (message "valid: %s" (w32notify-valid-p w)) (delete-directory mydir t) (run-with-idle-timer 1 nil (lambda () (message "valid: %s" (w32notify-valid-p w)))) When I run the above snippet with eval-region, I see these messages in *Messages*: Wrote d:/tmp/x/y valid: t (100161480 modified y) (100161480 removed y) valid: nil Try something similar with inotify and see if you see the same basic issue. If you do, I trust you will think of a way to modify the tests so that validation does do its thing.