From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 8ba156f: Attempt to avoid crashes in plist-member Date: Tue, 13 Oct 2015 18:32:41 +0300 Message-ID: <837fmqzsva.fsf@gnu.org> References: <20151012170324.17966.77@vcs.savannah.gnu.org> <83k2qro5eg.fsf@gnu.org> <561C7C26.3060408@cs.ucla.edu> <83io6azufx.fsf@gnu.org> <87zizm7qm3.fsf@fencepost.gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1444750446 25351 80.91.229.3 (13 Oct 2015 15:34:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 13 Oct 2015 15:34:06 +0000 (UTC) Cc: eggert@cs.ucla.edu, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: David Kastrup Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 13 17:33:53 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zm1aK-0000FB-LR for ged-emacs-devel@m.gmane.org; Tue, 13 Oct 2015 17:33:52 +0200 Original-Received: from localhost ([::1]:36899 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zm1aJ-0005WP-T4 for ged-emacs-devel@m.gmane.org; Tue, 13 Oct 2015 11:33:51 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48455) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zm1ZF-0005KG-0y for emacs-devel@gnu.org; Tue, 13 Oct 2015 11:32:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zm1Z9-00070u-AW for emacs-devel@gnu.org; Tue, 13 Oct 2015 11:32:44 -0400 Original-Received: from mtaout26.012.net.il ([80.179.55.182]:50146) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zm1Z5-0006zl-I4; Tue, 13 Oct 2015 11:32:35 -0400 Original-Received: from conversion-daemon.mtaout26.012.net.il by mtaout26.012.net.il (HyperSendmail v2007.08) id <0NW600M000E8YZ00@mtaout26.012.net.il>; Tue, 13 Oct 2015 18:35:33 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by mtaout26.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NW600LRC0N9JV20@mtaout26.012.net.il>; Tue, 13 Oct 2015 18:35:33 +0300 (IDT) In-reply-to: <87zizm7qm3.fsf@fencepost.gnu.org> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:191479 Archived-At: > From: David Kastrup > Cc: Paul Eggert , monnier@iro.umontreal.ca, emacs-devel@gnu.org > Date: Tue, 13 Oct 2015 17:08:52 +0200 > > CONSP only checks some bits on a pointer. It does not verify that > the pointer can be dereferenced into an existing cons cell. So there is > absolutely no need to modify anything between having a true CONSP test > and a crashing XCAR. Yes, well... I didn't have such a serious calamity in mind.