From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: bug#17453: Isearch doesn't work properly with Follow Mode. Date: Mon, 02 Nov 2015 05:35:27 +0200 Message-ID: <837fm1xedc.fsf@gnu.org> References: <20140509224458.GA4205@acm.acm> <20151029232302.GB3812@acm.fritz.box> <87h9l6627a.fsf@mail.linkov.net> <20151031235651.GE1853@acm.fritz.box> <87bnbddzpk.fsf@mail.linkov.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1446435337 16736 80.91.229.3 (2 Nov 2015 03:35:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 2 Nov 2015 03:35:37 +0000 (UTC) Cc: acm@muc.de, 17453@debbugs.gnu.org, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 02 04:35:29 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zt5u4-0002ep-Ke for ged-emacs-devel@m.gmane.org; Mon, 02 Nov 2015 04:35:28 +0100 Original-Received: from localhost ([::1]:39873 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zt5u3-00060m-JI for ged-emacs-devel@m.gmane.org; Sun, 01 Nov 2015 22:35:27 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54888) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zt5ty-00060h-Vu for emacs-devel@gnu.org; Sun, 01 Nov 2015 22:35:23 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zt5tu-00023g-4a for emacs-devel@gnu.org; Sun, 01 Nov 2015 22:35:22 -0500 Original-Received: from mtaout26.012.net.il ([80.179.55.182]:34568) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zt5tt-00023a-SY for emacs-devel@gnu.org; Sun, 01 Nov 2015 22:35:18 -0500 Original-Received: from conversion-daemon.mtaout26.012.net.il by mtaout26.012.net.il (HyperSendmail v2007.08) id <0NX6003004RZ0D00@mtaout26.012.net.il> for emacs-devel@gnu.org; Mon, 02 Nov 2015 05:38:45 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by mtaout26.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NX600H6Q4SLQI90@mtaout26.012.net.il>; Mon, 02 Nov 2015 05:38:45 +0200 (IST) In-reply-to: <87bnbddzpk.fsf@mail.linkov.net> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:193099 Archived-At: > From: Juri Linkov > Date: Mon, 02 Nov 2015 02:14:47 +0200 > Cc: 17453@debbugs.gnu.org, Stefan Monnier , > emacs-devel@gnu.org > > Since there is no other core library that require so much changes to > adapt to follow-mode, and there are already some mode-specific hooks > in follow.el like compilation-filter-hook, indicates that it's the > responsibility of follow.el to support isearch in follow-mode. So I > believe the right way to do this is like Artur presented in a short > patch, and maybe it's possible to simplify it even more by using > isearch-update-post-hook with a follow-align-compilation-windows > like hook. I mean something like (add-hook > 'isearch-update-post-hook follow-align-isearch-windows t t) I agree.