From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 504696d: Etags: yet another improvement in Ruby tags Date: Fri, 05 Feb 2016 16:34:43 +0200 Message-ID: <837fijusxo.fsf@gnu.org> References: <20160203162536.2954.45438@vcs.savannah.gnu.org> <56B29165.3040404@yandex.ru> <8337t9xhjc.fsf@gnu.org> <56B31B99.6010400@yandex.ru> <83io24wfjl.fsf@gnu.org> <56B4329D.7010101@yandex.ru> <83mvrfv7s3.fsf@gnu.org> <56B47566.5090806@yandex.ru> <83d1sbv25a.fsf@gnu.org> <56B4924A.2020207@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1454682909 17261 80.91.229.3 (5 Feb 2016 14:35:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 5 Feb 2016 14:35:09 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 05 15:35:08 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aRhTX-0006FV-T7 for ged-emacs-devel@m.gmane.org; Fri, 05 Feb 2016 15:35:08 +0100 Original-Received: from localhost ([::1]:48671 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRhTX-0001Jn-8V for ged-emacs-devel@m.gmane.org; Fri, 05 Feb 2016 09:35:07 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39320) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRhTR-0001H9-IU for emacs-devel@gnu.org; Fri, 05 Feb 2016 09:35:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aRhTO-0005PV-DS for emacs-devel@gnu.org; Fri, 05 Feb 2016 09:35:01 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59737) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRhTO-0005PQ-6i; Fri, 05 Feb 2016 09:34:58 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1687 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aRhTN-0007P4-FS; Fri, 05 Feb 2016 09:34:57 -0500 In-reply-to: <56B4924A.2020207@yandex.ru> (message from Dmitry Gutov on Fri, 5 Feb 2016 15:15:06 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:199382 Archived-At: > Cc: emacs-devel@gnu.org > From: Dmitry Gutov > Date: Fri, 5 Feb 2016 15:15:06 +0300 > > > I don't see how: the file names that trigger recognition as a specific > > language are part of the language-specific rules. > > I'd think we could mostly rely on the fact that the general facility > works, and you haven't made a typo in Ruby_filenames or Ruby_suffixes. Well, I almost surrendered to relying on such stuff when I added "Rakefile" and "Thorfile", and almost expected to see the same boring output when I tried that. It didn't, which is how the bug fixed in f6213ce was discovered. Which fits my general experience: there are no tests one can dismiss, every good test will always find some problem. > If you could write unit tests for etags code, you could have some for > the "detect language" function. Full-on integration tests, again, seem > like an overkill to me. I could agree with that, but we are a long way from having a unit test suite for Emacs.