From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#20787: 24.3; make-mode doesn't hightlight macro assignments preceeded by a TAB Date: Tue, 23 Feb 2016 18:16:45 +0200 Message-ID: <837fhvjtaq.fsf@gnu.org> References: <87k2lvu4dk.fsf@gnus.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1456244305 15040 80.91.229.3 (23 Feb 2016 16:18:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 23 Feb 2016 16:18:25 +0000 (UTC) Cc: 20787@debbugs.gnu.org, JFTrudeau@aetna.com To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Feb 23 17:18:14 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aYFf9-0001St-UT for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Feb 2016 17:18:12 +0100 Original-Received: from localhost ([::1]:58203 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYFf9-0002qK-EK for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Feb 2016 11:18:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35418) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYFf4-0002q4-BV for bug-gnu-emacs@gnu.org; Tue, 23 Feb 2016 11:18:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aYFf0-00060q-91 for bug-gnu-emacs@gnu.org; Tue, 23 Feb 2016 11:18:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44405) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYFf0-00060k-5I for bug-gnu-emacs@gnu.org; Tue, 23 Feb 2016 11:18:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aYFez-00030E-TP for bug-gnu-emacs@gnu.org; Tue, 23 Feb 2016 11:18:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Feb 2016 16:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20787 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 20787-submit@debbugs.gnu.org id=B20787.145624422311457 (code B ref 20787); Tue, 23 Feb 2016 16:18:01 +0000 Original-Received: (at 20787) by debbugs.gnu.org; 23 Feb 2016 16:17:03 +0000 Original-Received: from localhost ([127.0.0.1]:41532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYFe3-0002yj-Jp for submit@debbugs.gnu.org; Tue, 23 Feb 2016 11:17:03 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:44214) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYFe1-0002yA-Ia for 20787@debbugs.gnu.org; Tue, 23 Feb 2016 11:17:01 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aYFds-0005rj-II for 20787@debbugs.gnu.org; Tue, 23 Feb 2016 11:16:56 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43172) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYFds-0005rf-Er; Tue, 23 Feb 2016 11:16:52 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2520 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aYFdr-0002dt-FT; Tue, 23 Feb 2016 11:16:51 -0500 In-reply-to: <87k2lvu4dk.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 23 Feb 2016 21:07:19 +1100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:113590 Archived-At: > From: Lars Ingebrigtsen > Date: Tue, 23 Feb 2016 21:07:19 +1100 > Cc: 20787@debbugs.gnu.org > > "John F. Trudeau" writes: > > > The constant makefile-macroassign-regex (used for highlighting), in > > make-mode.el, does not find an assignment that is preceded by a TAB > > character. The attached patch corrects the regular expression to allow > > TAB as well as SPACE before an assignment, which corrects highlighting. > > > > -rw-r--r-- trudeajo/users 158 ChangeLog > > -rw-r--r-- trudeajo/users 2101 make-mode.el.patch > > > > This bug has endured through many emacs releases. > > I've detarred the patch and included it below, but I can't really say > whether it makes sense or not. Anybody? LGTM, thanks.