all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 23224@debbugs.gnu.org
Subject: bug#23224: 25.0.92; Can xref-find-references work without a "project"?
Date: Wed, 06 Apr 2016 20:08:59 +0300	[thread overview]
Message-ID: <837fgamzpw.fsf@gnu.org> (raw)
In-Reply-To: <e73a9694-63a2-3acf-b53a-c1d90fc9a8e1@yandex.ru> (message from Dmitry Gutov on Wed, 6 Apr 2016 03:18:09 +0300)

> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Wed, 6 Apr 2016 03:18:09 +0300
> 
> On 04/05/2016 06:23 PM, Eli Zaretskii wrote:
> 
> > +   (let* ((pr (project-current t nil 'noerror))
> > +          (roots (ignore-errors (project-roots pr)))
> > +          (eroots (ignore-errors (project-external-roots pr))))
> > +     ;; If we didn't find any project files in PR, default to PR
> > +     ;; itself as the project's single root.
> > +     (if (and (null roots) (null eroots))
> > +         (setq roots (list (expand-file-name pr))))
> > +     (append roots eroots))))
> 
> I'm going to assume you're teasing here. :)

A little bit.

> See the counter-proposal below, it should provide a more universal 
> benefit along the same line of reasoning. Unless we come upon situations 
> where we *do* want to abort with an error after asking the user for a 
> project and not finding a "real" one.

I don't know anything about project.el and its users, so I wasn't sure
such a change won't break something.  But if you say it's okay, I'll
stop worrying.

> If 'transient' doesn't sound great, alternative suggestions welcome.

"ad-hoc"?

Please go ahead and push.  Thanks.





  reply	other threads:[~2016-04-06 17:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-05 15:23 bug#23224: 25.0.92; Can xref-find-references work without a "project"? Eli Zaretskii
2016-04-05 17:22 ` John Wiegley
2016-04-06  0:18 ` Dmitry Gutov
2016-04-06 17:08   ` Eli Zaretskii [this message]
2016-04-06 23:08     ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=837fgamzpw.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=23224@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.