From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Another todo-mode bug fix, ok for emacs-25? Date: Wed, 04 May 2016 22:06:10 +0300 Message-ID: <837ff9iqxp.fsf@gnu.org> References: <87inyt7wls.fsf@gmx.net> <83zis5j1gw.fsf@gnu.org> <87eg9h7m30.fsf@gmx.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1462388805 30060 80.91.229.3 (4 May 2016 19:06:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 4 May 2016 19:06:45 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stephen Berman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 04 21:06:37 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ay280-0006Bi-VN for ged-emacs-devel@m.gmane.org; Wed, 04 May 2016 21:06:33 +0200 Original-Received: from localhost ([::1]:49759 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ay27x-0000KD-27 for ged-emacs-devel@m.gmane.org; Wed, 04 May 2016 15:06:29 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52211) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ay27o-0008W5-9F for emacs-devel@gnu.org; Wed, 04 May 2016 15:06:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ay27c-0005Wl-K6 for emacs-devel@gnu.org; Wed, 04 May 2016 15:06:14 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54085) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ay27c-0005Vs-HS; Wed, 04 May 2016 15:06:08 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2625 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1ay27V-0007P0-VI; Wed, 04 May 2016 15:06:02 -0400 In-reply-to: <87eg9h7m30.fsf@gmx.net> (message from Stephen Berman on Wed, 04 May 2016 19:46:27 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:203588 Archived-At: > From: Stephen Berman > Cc: emacs-devel@gnu.org > Date: Wed, 04 May 2016 19:46:27 +0200 > > The code changes are confined to the function todo-jump-to-category, > which can be invoked interactively and is also called noninteractively > from two other functions, todo-jump-to-archive-category and > todo-insert-category-line. The last of these uses is what give rise to > the bug, under the conditions given in the bug report (archived items, > non-nil todo-skip-archived-categories). With the fix applied, I've also > tested this use when these conditions are not met, and I've tested the > other noninteractive use and the interactive uses (the command can be > called not only within Todo mode but also from a non-Todo mode buffer). > In all of my tests with the patched code, the behavior was as expected. Thanks, I'm sold.