From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: On controlling rectangle-preview Date: Thu, 21 Jul 2016 17:28:40 +0300 Message-ID: <837fcfysiv.fsf@gnu.org> References: <87wpkhgq5i.fsf@udel.edu> <20160720022539.GA25914@holos.localdomain> <20160720230047.GA18198@holos.localdomain> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1469111402 14715 80.91.229.3 (21 Jul 2016 14:30:02 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 21 Jul 2016 14:30:02 +0000 (UTC) Cc: mvoteiza@udel.edu, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: John Wiegley Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 21 16:30:01 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bQEz9-0008VQ-2h for ged-emacs-devel@m.gmane.org; Thu, 21 Jul 2016 16:29:59 +0200 Original-Received: from localhost ([::1]:41156 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQEz8-0000Xi-7q for ged-emacs-devel@m.gmane.org; Thu, 21 Jul 2016 10:29:58 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38411) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQExo-0000BA-DC for emacs-devel@gnu.org; Thu, 21 Jul 2016 10:28:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQExn-0002eI-CZ for emacs-devel@gnu.org; Thu, 21 Jul 2016 10:28:36 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49376) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQExn-0002dW-9P; Thu, 21 Jul 2016 10:28:35 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4919 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bQExl-0001Ta-9j; Thu, 21 Jul 2016 10:28:33 -0400 In-reply-to: (message from John Wiegley on Thu, 21 Jul 2016 00:03:25 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:205955 Archived-At: > From: John Wiegley > Cc: Stefan Monnier , emacs-devel@gnu.org, Eli Zaretskii > Date: Thu, 21 Jul 2016 00:03:25 -0700 > > > This ends up bring very simple--permission to push to emacs-25? > > If Eli agrees, it looks safe enough to me for the release. Sorry, I'm confused by the last message in the discussion of the patch. This started by introducing a new defcustom that controls the preview, but ended with a patch adding no defcustom and instead deleting 3 lines? What did I miss (specifically between http://lists.gnu.org/archive/html/emacs-devel/2016-07/msg00845.html, which approves the original patch, and http://lists.gnu.org/archive/html/emacs-devel/2016-07/msg00911.html, which presents a totally different one)? And why is it needed in emacs-25? Is there some urgent or particularly nasty problem involved that we'd like to fix ASAP? Thanks.