From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24317: 25.1.50; image-dired-rotate-original: regexp doesn't match .jpeg suffix Date: Sat, 27 Aug 2016 15:55:22 +0300 Message-ID: <837fb2cqx1.fsf@gnu.org> References: <83d1kud3m1.fsf@gnu.org> <83a8fyd1x0.fsf@gnu.org> <87oa4e1raw.fsf@zigzag.favinet> <838tvicuy3.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1472302581 29438 195.159.176.226 (27 Aug 2016 12:56:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 27 Aug 2016 12:56:21 +0000 (UTC) Cc: ttn@gnu.org, 24317@debbugs.gnu.org To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 27 14:56:17 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bdd9k-0007C0-HJ for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Aug 2016 14:56:16 +0200 Original-Received: from localhost ([::1]:35973 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdd9h-0006Hy-WD for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Aug 2016 08:56:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59660) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdd9c-0006Ht-OE for bug-gnu-emacs@gnu.org; Sat, 27 Aug 2016 08:56:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bdd9W-0007W8-RD for bug-gnu-emacs@gnu.org; Sat, 27 Aug 2016 08:56:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44188) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdd9W-0007W4-Nh for bug-gnu-emacs@gnu.org; Sat, 27 Aug 2016 08:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bdd9W-0007Hx-IO for bug-gnu-emacs@gnu.org; Sat, 27 Aug 2016 08:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Aug 2016 12:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24317 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24317-submit@debbugs.gnu.org id=B24317.147230251827958 (code B ref 24317); Sat, 27 Aug 2016 12:56:02 +0000 Original-Received: (at 24317) by debbugs.gnu.org; 27 Aug 2016 12:55:18 +0000 Original-Received: from localhost ([127.0.0.1]:41900 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bdd8o-0007Gr-19 for submit@debbugs.gnu.org; Sat, 27 Aug 2016 08:55:18 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:40346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bdd8m-0007Gf-Lo for 24317@debbugs.gnu.org; Sat, 27 Aug 2016 08:55:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bdd8g-0007A3-JV for 24317@debbugs.gnu.org; Sat, 27 Aug 2016 08:55:11 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37302) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdd8W-00072S-T2; Sat, 27 Aug 2016 08:55:00 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2109 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bdd8U-00063T-WD; Sat, 27 Aug 2016 08:54:59 -0400 In-reply-to: (message from Tino Calancha on Sat, 27 Aug 2016 21:18:37 +0900 (JST)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122722 Archived-At: > From: Tino Calancha > Date: Sat, 27 Aug 2016 21:18:37 +0900 (JST) > cc: Thien-Thi Nguyen , tino.calancha@gmail.com, > 24317@debbugs.gnu.org > > > That is better, yes. Except that > > > > (let ((case-fold-search)) (image-type-from-file-name "foo.JPEG")) > > => nil > > > > So I guess that function needs a minor change to be more robust. > That's right. It wuld be worth take a look on > 'image-type-from-file-name'. > > I have corrected previous patch. I drop expand-file-name from > 'image-dired-jpeg-file-p'. I also corrected the extra paren mentioned > before. > If people is happy with it i will apply this patch. I think we should indeed use image-type instead of having yet another function that recognizes JPEG. The problem I pointed out should be fixed in image-type-from-file-name, regardless. Sorry this wasn't clear enough from what I wrote before.