From: Eli Zaretskii <eliz@gnu.org>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: 24393@debbugs.gnu.org
Subject: bug#24393: 25.1.50; image-mode ignore the image :scale
Date: Fri, 09 Sep 2016 16:15:58 +0300 [thread overview]
Message-ID: <837fal8b8x.fsf@gnu.org> (raw)
In-Reply-To: <alpine.DEB.2.20.1609091910430.28410@calancha-pc> (message from Tino Calancha on Fri, 9 Sep 2016 19:23:02 +0900 (JST))
> From: Tino Calancha <tino.calancha@gmail.com>
> Date: Fri, 9 Sep 2016 19:23:02 +0900 (JST)
> cc: Tino Calancha <tino.calancha@gmail.com>, 24393@debbugs.gnu.org
>
> > ;; If we have a `fit-width' or a `fit-height', don't limit
> > ;; the size of the image to the window size.
> > (edges (and (null image-transform-resize)
> > (window-inside-pixel-edges
> > (get-buffer-window (current-buffer)))))
> >
> > I think 'edges' should be non-nil if image-transform-resize is
> > non-nil, no?
> I think is OK. Maybe i would adjust the comment a bit, because
> `image-transform-resize' can also be a number (set by
> `image-transform-set-scale'): i would say:
> ;; If `image-transform-resize' is non-nil, don't limit
> ;; the size of the image to the window size.
>
> I think the logic is as follows:
> The proportion width/height is an invariant of this transformation.
> If you call `image-transform-fit-to-width', your image width will occupy
> all the window width. Then, the height is increased in the same
> proportion as the width, so the final image height may be longer than
> the window height. That's OK.
When image-transform-fit-to-width sets image-transform-resize to the
symbol 'fit-width', image-toggle-display-image will not pass any
dimensions to create-image. So how will the image be resized at all
in this case? What am I missing?
And how do you explain the assertion violation in this case, anyway?
What are the window dimensions in pixels?
next prev parent reply other threads:[~2016-09-09 13:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 12:14 bug#24393: 25.1.50; image-mode ignore the image :scale Tino Calancha
2016-09-08 17:15 ` Eli Zaretskii
2016-09-08 18:13 ` Tino Calancha
2016-09-09 8:06 ` Eli Zaretskii
2016-09-09 10:23 ` Tino Calancha
2016-09-09 13:15 ` Eli Zaretskii [this message]
2016-09-09 13:51 ` Tino Calancha
2019-09-26 15:59 ` Lars Ingebrigtsen
2019-09-26 17:42 ` Tino Calancha
2019-09-26 17:49 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837fal8b8x.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=24393@debbugs.gnu.org \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.