From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24518: 25.2.50; dired-mark-extension with prefix arg fails Date: Sat, 24 Sep 2016 14:52:18 +0300 Message-ID: <837fa1cy6l.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1474718108 5487 195.159.176.226 (24 Sep 2016 11:55:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 24 Sep 2016 11:55:08 +0000 (UTC) Cc: 24518@debbugs.gnu.org To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 24 13:55:02 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnlXa-0006zq-6L for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Sep 2016 13:54:46 +0200 Original-Received: from localhost ([::1]:60558 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnlXY-0004Pg-1t for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Sep 2016 07:54:44 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38451) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnlVy-0003Bq-Ck for bug-gnu-emacs@gnu.org; Sat, 24 Sep 2016 07:53:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bnlVu-0002ri-5b for bug-gnu-emacs@gnu.org; Sat, 24 Sep 2016 07:53:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55986) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnlVu-0002rW-1j for bug-gnu-emacs@gnu.org; Sat, 24 Sep 2016 07:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bnlVt-0004tw-NB for bug-gnu-emacs@gnu.org; Sat, 24 Sep 2016 07:53:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Sep 2016 11:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24518 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24518-submit@debbugs.gnu.org id=B24518.147471794318791 (code B ref 24518); Sat, 24 Sep 2016 11:53:01 +0000 Original-Received: (at 24518) by debbugs.gnu.org; 24 Sep 2016 11:52:23 +0000 Original-Received: from localhost ([127.0.0.1]:33943 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnlVH-0004t1-Cg for submit@debbugs.gnu.org; Sat, 24 Sep 2016 07:52:23 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:47201) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bnlVF-0004so-Vv for 24518@debbugs.gnu.org; Sat, 24 Sep 2016 07:52:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bnlV7-0002XJ-NB for 24518@debbugs.gnu.org; Sat, 24 Sep 2016 07:52:16 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37040) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnlV7-0002Ww-Ju; Sat, 24 Sep 2016 07:52:13 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1117 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bnlUz-0000J4-0g; Sat, 24 Sep 2016 07:52:12 -0400 In-reply-to: (message from Tino Calancha on Fri, 23 Sep 2016 23:13:52 +0900 (JST)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:123627 Archived-At: > From: Tino Calancha > Date: Fri, 23 Sep 2016 23:13:52 +0900 (JST) > Cc: tino.calancha@gmail.com > > > emacs -Q ~ -eval "(require 'dired-x)" > C-u * . el RET > ;; signal error: > Wrong type argument: char-or-string-p, (4) > > Because the interactive specification read MARKER-CHAR using 'P'. > That would be sensical if prefix argument has the meaning of unmark > files. That behaviour is found elsewhere in Dired, for instance, > `dired-mark-executables', `dired-mark-directories', > `dired-mark-files-regexp'. > > In following patch, `dired-mark-extension' with a prefix argument > unmark files: This loses the feature whereby the user could also specify the character to use as the marker. Try "C-u 65 * . el RET" to see what that does. While using the numeric code of a character sounds like a kludge, the current implementation seems to do that deliberately. It might make sense to use 'c' instead of 'P' there, I think, but your patch totally changes the semantics of the prefix argument, so I'm not sure I can endorse such a change. Thanks.