From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24555: [PATCH] Remove unused variable `command-debug-status' Date: Wed, 28 Sep 2016 17:58:41 +0300 Message-ID: <837f9woyu6.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1475074766 28427 195.159.176.226 (28 Sep 2016 14:59:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 28 Sep 2016 14:59:26 +0000 (UTC) Cc: Stefan Monnier , 24555@debbugs.gnu.org To: Philippe Vaucher Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 28 16:59:16 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bpGKG-00066R-HE for geb-bug-gnu-emacs@m.gmane.org; Wed, 28 Sep 2016 16:59:12 +0200 Original-Received: from localhost ([::1]:59388 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpGKF-0008Lb-1F for geb-bug-gnu-emacs@m.gmane.org; Wed, 28 Sep 2016 10:59:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42537) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpGK6-0008KY-W7 for bug-gnu-emacs@gnu.org; Wed, 28 Sep 2016 10:59:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bpGK6-0006ll-3y for bug-gnu-emacs@gnu.org; Wed, 28 Sep 2016 10:59:02 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60086) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpGK6-0006lh-18 for bug-gnu-emacs@gnu.org; Wed, 28 Sep 2016 10:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bpGK5-0007bN-PF for bug-gnu-emacs@gnu.org; Wed, 28 Sep 2016 10:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Sep 2016 14:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24555 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24555-submit@debbugs.gnu.org id=B24555.147507473729212 (code B ref 24555); Wed, 28 Sep 2016 14:59:01 +0000 Original-Received: (at 24555) by debbugs.gnu.org; 28 Sep 2016 14:58:57 +0000 Original-Received: from localhost ([127.0.0.1]:38043 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bpGK1-0007b6-Ih for submit@debbugs.gnu.org; Wed, 28 Sep 2016 10:58:57 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:51490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bpGJz-0007at-RG for 24555@debbugs.gnu.org; Wed, 28 Sep 2016 10:58:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bpGJt-0006gT-Np for 24555@debbugs.gnu.org; Wed, 28 Sep 2016 10:58:50 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57982) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpGJo-0006eQ-N9; Wed, 28 Sep 2016 10:58:44 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1194 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bpGJk-000098-RS; Wed, 28 Sep 2016 10:58:41 -0400 In-reply-to: (message from Philippe Vaucher on Wed, 28 Sep 2016 14:39:02 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:123734 Archived-At: > From: Philippe Vaucher > Date: Wed, 28 Sep 2016 14:39:02 +0200 > > For information, I did the procedure for copyright assignment to Emacs and it is complete. Indeed, your assignment is on file. > This patch removes the variable `command-debug-status', which really seems to be unused since a long time > to me (that's what "git -G Vcommand-debug-status" says). Thanks for bringing this up. I looked into the history of this variable, and found that it was still supported in Emacs 24.5, and was removed during development of Emacs 25 by this commit: commit 0e4857b7d84f958f66e726ed57b824427b272681 Author: Stefan Monnier Date: Tue May 27 20:09:14 2014 -0400 * src/callint.c (Ffuncall_interactively): New function. (Qfuncall_interactively): New var. (Qcall_interactively): Remove. (Fcall_interactively): Use it. (syms_of_callint): Defsubr it. * lisp/subr.el (internal--funcall-interactively): New. (internal--call-interactively): Remove. (called-interactively-p): Detect funcall-interactively instead of call-interactively. * lisp/simple.el (repeat-complex-command): Use funcall-interactively. (repeat-complex-command--called-interactively-skip): Remove. As you see, the commit log doesn't mention the removal of the variable. Stefan, was it removed on purpose? If so, can you tell why? Thanks.