From: Eli Zaretskii <eliz@gnu.org>
To: Philippe Vaucher <philippe.vaucher@gmail.com>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, 24555@debbugs.gnu.org
Subject: bug#24555: [PATCH] Remove unused variable `command-debug-status'
Date: Wed, 28 Sep 2016 17:58:41 +0300 [thread overview]
Message-ID: <837f9woyu6.fsf@gnu.org> (raw)
In-Reply-To: <CAGK7Mr51xxak63=JUa4_Tm+3BB-8LYejsJQxdx39BX1_UsNcKg@mail.gmail.com> (message from Philippe Vaucher on Wed, 28 Sep 2016 14:39:02 +0200)
> From: Philippe Vaucher <philippe.vaucher@gmail.com>
> Date: Wed, 28 Sep 2016 14:39:02 +0200
>
> For information, I did the procedure for copyright assignment to Emacs and it is complete.
Indeed, your assignment is on file.
> This patch removes the variable `command-debug-status', which really seems to be unused since a long time
> to me (that's what "git -G Vcommand-debug-status" says).
Thanks for bringing this up.
I looked into the history of this variable, and found that it was
still supported in Emacs 24.5, and was removed during development of
Emacs 25 by this commit:
commit 0e4857b7d84f958f66e726ed57b824427b272681
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Date: Tue May 27 20:09:14 2014 -0400
* src/callint.c (Ffuncall_interactively): New function.
(Qfuncall_interactively): New var.
(Qcall_interactively): Remove.
(Fcall_interactively): Use it.
(syms_of_callint): Defsubr it.
* lisp/subr.el (internal--funcall-interactively): New.
(internal--call-interactively): Remove.
(called-interactively-p): Detect funcall-interactively instead of
call-interactively.
* lisp/simple.el (repeat-complex-command): Use funcall-interactively.
(repeat-complex-command--called-interactively-skip): Remove.
As you see, the commit log doesn't mention the removal of the
variable. Stefan, was it removed on purpose? If so, can you tell
why?
Thanks.
next prev parent reply other threads:[~2016-09-28 14:58 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-28 12:39 bug#24555: [PATCH] Remove unused variable `command-debug-status' Philippe Vaucher
2016-09-28 14:58 ` Eli Zaretskii [this message]
2016-09-28 16:14 ` Stefan Monnier
2016-09-28 17:24 ` Philippe Vaucher
2016-09-28 20:11 ` Eli Zaretskii
2016-09-29 0:16 ` Stefan Monnier
2016-09-29 6:50 ` Philippe Vaucher
2016-09-29 15:04 ` Eli Zaretskii
2016-09-30 9:08 ` Philippe Vaucher
2016-10-01 13:09 ` Philippe Vaucher
2016-10-01 15:50 ` Eli Zaretskii
2016-10-01 16:12 ` Philippe Vaucher
2016-10-01 17:39 ` Eli Zaretskii
2016-10-02 17:08 ` Philippe Vaucher
2016-10-02 18:32 ` Noam Postavsky
2016-10-02 18:48 ` Philippe Vaucher
2016-10-02 19:41 ` Philippe Vaucher
2016-10-03 7:13 ` Eli Zaretskii
2016-10-03 7:37 ` Philippe Vaucher
2016-10-03 7:42 ` Philippe Vaucher
2016-10-04 14:43 ` Eli Zaretskii
2016-10-04 15:18 ` Philippe Vaucher
2016-10-04 15:46 ` Eli Zaretskii
2016-10-04 15:54 ` Philippe Vaucher
2016-09-28 20:05 ` Eli Zaretskii
2016-09-29 0:12 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837f9woyu6.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=24555@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=philippe.vaucher@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.