From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24603: [RFC 16/18] Refactor character class checking; optimise ASCII case Date: Tue, 04 Oct 2016 10:48:36 +0300 Message-ID: <837f9oo8q3.fsf@gnu.org> References: <1475543441-10493-1-git-send-email-mina86@mina86.com> <1475543441-10493-16-git-send-email-mina86@mina86.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1475567380 1799 195.159.176.226 (4 Oct 2016 07:49:40 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 4 Oct 2016 07:49:40 +0000 (UTC) Cc: 24603@debbugs.gnu.org To: Michal Nazarewicz Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 04 09:49:36 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1brKTZ-0006cA-Fo for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Oct 2016 09:49:21 +0200 Original-Received: from localhost ([::1]:40670 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brKTW-0004lQ-Vv for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Oct 2016 03:49:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46661) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brKTM-0004l2-53 for bug-gnu-emacs@gnu.org; Tue, 04 Oct 2016 03:49:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1brKTG-0003Bi-6H for bug-gnu-emacs@gnu.org; Tue, 04 Oct 2016 03:49:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37556) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brKTG-0003BW-2p for bug-gnu-emacs@gnu.org; Tue, 04 Oct 2016 03:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1brKTF-0002Qd-UJ for bug-gnu-emacs@gnu.org; Tue, 04 Oct 2016 03:49:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Oct 2016 07:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24603 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24603-submit@debbugs.gnu.org id=B24603.14755673329314 (code B ref 24603); Tue, 04 Oct 2016 07:49:01 +0000 Original-Received: (at 24603) by debbugs.gnu.org; 4 Oct 2016 07:48:52 +0000 Original-Received: from localhost ([127.0.0.1]:43746 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1brKT6-0002QA-4s for submit@debbugs.gnu.org; Tue, 04 Oct 2016 03:48:52 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:55575) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1brKT4-0002Pv-Jp for 24603@debbugs.gnu.org; Tue, 04 Oct 2016 03:48:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1brKSu-0002r2-GR for 24603@debbugs.gnu.org; Tue, 04 Oct 2016 03:48:45 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43967) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brKSu-0002qG-Cq; Tue, 04 Oct 2016 03:48:40 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2521 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1brKSs-00012U-4t; Tue, 04 Oct 2016 03:48:38 -0400 In-reply-to: <1475543441-10493-16-git-send-email-mina86@mina86.com> (message from Michal Nazarewicz on Tue, 4 Oct 2016 03:10:39 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:124025 Archived-At: > From: Michal Nazarewicz > Date: Tue, 4 Oct 2016 03:10:39 +0200 > > +const unsigned char category_char_bits[] = { > + [UNICODE_CATEGORY_UNKNOWN] = 0, > + [UNICODE_CATEGORY_Lu] = CHAR_BIT_ALPHA_ | CHAR_BIT_UPPER, > + [UNICODE_CATEGORY_Ll] = CHAR_BIT_ALPHA_ | CHAR_BIT_LOWER, Is this syntax portable enough for us to use it? > +/* Limited set of character categories which syntax-independent. Testing of ^^^^^^^^^^^^^^^^^^^^^^^^ "which are syntax-independent" > + * those characters do not require any run-time data, e.g. do not depend on ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ "does not require" and "does not depend" Thanks. I think this change will require a benchmark to make sure we don't lose too much in terms of performance.