From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#26892: 25.2; whitespace-mode does not turn off correctly Date: Fri, 12 May 2017 09:19:52 +0300 Message-ID: <837f1ma96f.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1494570076 11206 195.159.176.226 (12 May 2017 06:21:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 12 May 2017 06:21:16 +0000 (UTC) Cc: 26892@debbugs.gnu.org To: Nick Helm Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 12 08:21:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d93wq-0002ij-Uy for geb-bug-gnu-emacs@m.gmane.org; Fri, 12 May 2017 08:21:09 +0200 Original-Received: from localhost ([::1]:51595 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d93ww-00077L-Fh for geb-bug-gnu-emacs@m.gmane.org; Fri, 12 May 2017 02:21:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43461) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d93wn-00076x-NN for bug-gnu-emacs@gnu.org; Fri, 12 May 2017 02:21:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d93wk-0003L2-Ic for bug-gnu-emacs@gnu.org; Fri, 12 May 2017 02:21:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36952) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d93wk-0003KV-B5 for bug-gnu-emacs@gnu.org; Fri, 12 May 2017 02:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d93wk-0005w1-6v for bug-gnu-emacs@gnu.org; Fri, 12 May 2017 02:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 May 2017 06:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26892 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 26892-submit@debbugs.gnu.org id=B26892.149457001322732 (code B ref 26892); Fri, 12 May 2017 06:21:02 +0000 Original-Received: (at 26892) by debbugs.gnu.org; 12 May 2017 06:20:13 +0000 Original-Received: from localhost ([127.0.0.1]:39629 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d93vw-0005ua-Nr for submit@debbugs.gnu.org; Fri, 12 May 2017 02:20:12 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:52375) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d93vu-0005uO-PZ for 26892@debbugs.gnu.org; Fri, 12 May 2017 02:20:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d93vm-0002eR-KS for 26892@debbugs.gnu.org; Fri, 12 May 2017 02:20:05 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37890) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d93vm-0002eM-HL; Fri, 12 May 2017 02:20:02 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1708 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1d93vl-0002u1-Tj; Fri, 12 May 2017 02:20:02 -0400 In-reply-to: (message from Nick Helm on Fri, 12 May 2017 11:34:33 +1200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:132457 Archived-At: > From: Nick Helm > Date: Fri, 12 May 2017 11:34:33 +1200 > > Emacs -Q > C-u 20 SPC RET RET RET RET ; type some random whitespace > M-x global-whitespace-mode > M-x whitespace-mode > M-x whitespace-mode > > The last command should toggle local whitespace-mode off, but note that the > whitespace display characters are not properly removed from the current > buffer. > > I had a look at whitespace.el and I think the problem lies in > `whitespace-display-char-on'. Among other things, this function stores the > buffer display table and replaces it with a temporary display table to show > whitespace chars. The original is restored when the mode is turned off. > > However, with global-whitespace-mode active, there is already a temporary > display table in place, which whitespace-mode incorrectly picks up and stores, > clobbering the original display table in the process. When whitespace-mode is > turned off, it restores the temporary display table set by > global-whitespace-mode, which leads to the problem. > > Here's a little patch to check if global-whitespace-mode is active before > storing the display table. I've tried this for a few days with no obvious > problems. Did you try running whitespace-tests with this change, and if so, did they pass? If the tests pass, would you mind to please add a new test for this bug? Thanks.