From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Reimplement module functions Date: Sun, 14 May 2017 17:11:22 +0300 Message-ID: <837f1j8r5h.fsf@gnu.org> References: <20170513144408.14057-1-phst@google.com> <83fug88z76.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1494771109 30192 195.159.176.226 (14 May 2017 14:11:49 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 14 May 2017 14:11:49 +0000 (UTC) Cc: phst@google.com, p.stephani2@gmail.com, emacs-devel@gnu.org To: Noam Postavsky Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun May 14 16:11:43 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d9uFL-0007jM-1F for ged-emacs-devel@m.gmane.org; Sun, 14 May 2017 16:11:43 +0200 Original-Received: from localhost ([::1]:32876 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d9uFQ-0000o8-Jt for ged-emacs-devel@m.gmane.org; Sun, 14 May 2017 10:11:48 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50552) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d9uFK-0000nr-Kk for emacs-devel@gnu.org; Sun, 14 May 2017 10:11:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d9uFH-0000yz-HF for emacs-devel@gnu.org; Sun, 14 May 2017 10:11:42 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33552) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d9uFH-0000yt-DI; Sun, 14 May 2017 10:11:39 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1929 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1d9uFG-0007qY-Gl; Sun, 14 May 2017 10:11:38 -0400 In-reply-to: (message from Noam Postavsky on Sat, 13 May 2017 23:07:26 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214840 Archived-At: > From: Noam Postavsky > Date: Sat, 13 May 2017 23:07:26 -0400 > Cc: Philipp Stephani , Philipp Stephani , > Emacs developers > > > I don't think we can simply remove a function that was already present > > in one or more Emacs releases. We need to provide a backward > > compatibility layer, and definitely also mention this in NEWS. > > Does an internal function like 'internal--module-call' really need all > that? AFAIK, it was not really meant to be used except in the > implementation of module_make_function. We don't _have_ to do that, but if it's not too hard, why not be nice to our users and keep providing it? Maybe I'm missing something, but it seemed to me that a simple wrapper around funcall_module or its part would do. We can declare it obsolete and remove it at some future point.