From: Eli Zaretskii <eliz@gnu.org>
To: Winston <wbe@psr.com>
Cc: 28403@debbugs.gnu.org, dgutov@yandex.ru
Subject: bug#28403: 25.2; find-tag works, but xref-find-definitions
Date: Sun, 10 Sep 2017 17:29:32 +0300 [thread overview]
Message-ID: <837ex6vd83.fsf@gnu.org> (raw)
In-Reply-To: <201709100250.v8A2o6nL015568@psr.com> (message from Winston on Sat, 9 Sep 2017 22:50 EDT)
> Date: Sat, 9 Sep 2017 22:50 EDT
> From: Winston <wbe@psr.com>
>
> Dmitry kindly replied:
> > Which program are you generating TAGS with? Is it etags that comes with
> > Emacs?
>
> Yes, and "etags --version" prints: etags (GNU Emacs 25.2)
>
> > xref-find-definitions is somewhat stricter about its input than
> > find-tag.
>
> Yes, that's what's causing the difference. ;-)
>
> > What does the entry for this function inside TAGS look like? [...]
> > I'm guessing it looks like:
> >
> > name _ARGS1(
>
> Exactly. E.g.,
> name _ARGS1(^?188,5710
Thanks. Could you please post a complete example of the code in
question, including the definition of the _ARGS1 macro, and any other
macros and typedefs that would make the example stand-alone? I think
I understand what has happened, but I'd like to be sure before we
decide what to do about it.
> > Try adding `tag-symbol-match-p' to
> > etags-xref-find-definitions-tag-order. This example should work then,
> > but you'll get more false positives (like treating return types as
> > function names).
Dmitry, how about providing a more user-friendly customization to that
effect? As a "fire escape"?
> For the moment I think I'll just continue to use find-tag and hope
> that xref-find-definitions will eventually work as well as find-tag
> before find-tag disappears. :)
I'd rather like to encourage you to continue using xref and report any
issue you find. We want to make xref as good as the features it
replaces and better. It is already better in several areas: it is
much more accurate (so many times lands you right on the spot, whereas
find-tag might require to go sequentially through several
alternatives), and in the rare cases where there are more than a
single candidate, it allows you to select the right one much faster.
We would like to solve any remaining problems, and that will be much
harder if people don't report those problems to us. It is even
possible that, given the details I requested above, I will be able to
help you get your use case working with xref, so please don't give up
on xref, not just yet.
Thanks.
next prev parent reply other threads:[~2017-09-10 14:29 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-09 22:40 bug#28403: 25.2; find-tag works, but xref-find-definitions doesn't; bug? Winston
2017-09-09 22:58 ` Drew Adams
2017-09-09 23:10 ` Dmitry Gutov
2017-09-10 2:50 ` bug#28403: 25.2; find-tag works, but xref-find-definitions Winston
2017-09-10 9:01 ` Dmitry Gutov
2017-09-10 14:29 ` Eli Zaretskii [this message]
2017-09-10 21:43 ` Dmitry Gutov
2017-09-11 2:38 ` Eli Zaretskii
2017-09-11 8:58 ` Dmitry Gutov
2017-09-11 14:43 ` Eli Zaretskii
2017-09-12 23:40 ` Dmitry Gutov
2017-09-13 15:32 ` Eli Zaretskii
2017-09-14 12:13 ` Dmitry Gutov
2017-09-14 17:13 ` Eli Zaretskii
2017-09-19 0:44 ` Dmitry Gutov
2017-09-19 3:58 ` Eli Zaretskii
2017-09-10 14:52 ` Winston
2017-09-10 18:27 ` Winston
2017-09-10 19:09 ` Eli Zaretskii
2017-09-10 19:06 ` Winston
2017-09-10 19:10 ` Winston
2017-09-10 20:12 ` Winston
2017-09-11 2:31 ` Eli Zaretskii
2017-09-10 21:19 ` Winston
2017-09-10 21:35 ` Dmitry Gutov
2017-09-11 2:34 ` Eli Zaretskii
2017-09-11 3:19 ` Winston
2017-09-11 4:05 ` Winston
2017-09-11 16:23 ` Eli Zaretskii
2017-09-11 4:11 ` Winston
2017-09-11 5:02 ` Winston
2017-09-11 16:51 ` Eli Zaretskii
2017-09-14 17:37 ` Winston
2017-09-14 22:08 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837ex6vd83.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=28403@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=wbe@psr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.