all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 28483@debbugs.gnu.org, plaice.adam+lists@gmail.com,
	28520@debbugs.gnu.org, aaronjensen@gmail.com,
	tino.calancha@gmail.com
Subject: bug#28520: bug#28483: 26.0.50; copy-directory does not create directories
Date: Wed, 20 Sep 2017 22:54:26 +0300	[thread overview]
Message-ID: <837ewtf8nh.fsf@gnu.org> (raw)
In-Reply-To: <be3fa356-6f9a-e470-2bb8-c9a2a0bc0095@cs.ucla.edu> (message from Paul Eggert on Wed, 20 Sep 2017 11:59:37 -0700)

> Cc: 28483@debbugs.gnu.org, aaronjensen@gmail.com, 28520-done@debbugs.gnu.org,
>  Adam Plaice <plaice.adam+lists@gmail.com>,
>  Tino Calancha <tino.calancha@gmail.com>
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Wed, 20 Sep 2017 11:59:37 -0700
> 
> Thanks for diagnosing the problem and for the fix. That fix should work, 
> and I think we can improve on it slightly by using (copy-directory file 
> target keep-time parents t), as this makes the cond branch more parallel 
> with the other alternatives and avoids a call to file-name-as-directory. 
> So I installed the attached patch into the emacs-26 branch to do that, 
> and to add a test case for this bug.

Thanks, works for me.





  reply	other threads:[~2017-09-20 19:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-17 19:10 bug#28483: 26.0.50; copy-directory does not create directories Aaron Jensen
2017-09-17 19:15 ` bug#28483: [PATCH] Fix copy-directory creating missing directory Aaron Jensen
2017-09-17 19:48   ` Philipp Stephani
2017-09-17 20:19     ` Aaron Jensen
2017-09-18 17:40       ` Philipp Stephani
2017-09-17 19:20 ` bug#28483: 26.0.50; copy-directory does not create directories Aaron Jensen
2017-09-17 20:40   ` Paul Eggert
2017-09-17 23:12     ` Aaron Jensen
2017-09-17 23:52       ` Paul Eggert
2017-09-20 11:26     ` Eli Zaretskii
2017-09-20 18:59       ` bug#28520: " Paul Eggert
2017-09-20 19:54         ` Eli Zaretskii [this message]
2017-09-20 23:04           ` Adam Plaice

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=837ewtf8nh.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=28483@debbugs.gnu.org \
    --cc=28520@debbugs.gnu.org \
    --cc=aaronjensen@gmail.com \
    --cc=eggert@cs.ucla.edu \
    --cc=plaice.adam+lists@gmail.com \
    --cc=tino.calancha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.