From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Lisp primitives and their calling of the change hooks Date: Mon, 08 Jan 2018 05:41:02 +0200 Message-ID: <837est81bl.fsf@gnu.org> References: <20180107113628.GA22254@ACM> <83o9m599du.fsf@gnu.org> <20180107120859.GB22254@ACM> <20180107135629.GC22254@ACM> <83mv1p8vki.fsf@gnu.org> <83bmi58sao.fsf@gnu.org> <20180107194845.GE22254@ACM> <838td98mqe.fsf@gnu.org> <20180107211055.GF22254@ACM> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1515382804 18590 195.159.176.226 (8 Jan 2018 03:40:04 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 8 Jan 2018 03:40:04 +0000 (UTC) Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 08 04:40:00 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYOI1-0004Pt-Ge for ged-emacs-devel@m.gmane.org; Mon, 08 Jan 2018 04:39:57 +0100 Original-Received: from localhost ([::1]:33923 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYOK0-0004Ct-TG for ged-emacs-devel@m.gmane.org; Sun, 07 Jan 2018 22:42:00 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36800) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYOJN-0004CQ-AC for emacs-devel@gnu.org; Sun, 07 Jan 2018 22:41:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eYOJK-0006S3-8G for emacs-devel@gnu.org; Sun, 07 Jan 2018 22:41:21 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53905) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYOJK-0006Rw-4R; Sun, 07 Jan 2018 22:41:18 -0500 Original-Received: from [176.228.60.248] (port=2784 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eYOJJ-0000Lo-7R; Sun, 07 Jan 2018 22:41:17 -0500 In-reply-to: <20180107211055.GF22254@ACM> (message from Alan Mackenzie on Sun, 7 Jan 2018 21:10:55 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:221699 Archived-At: > Date: Sun, 7 Jan 2018 21:10:55 +0000 > Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org > From: Alan Mackenzie > > > Like I said, I think we should have only one pair of hooks, like we > > have in replace_range. > > OK. This is slightly more awkward: del_range needs to be replaced by > del_range_2, so as not to get an extra call to signal_after_change. You need a call to update_compositions after del_range_2, to mimic what del_range does, I think. > There is also no a-c-f call if the decompression exits with an error. You mean, if the user quits? That throws to top level, so it would be wrong to invoke any after-change hooks, and unwind_decompress will call the hooks for the partially uncompressed data. Do we need more? Thanks.