From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#30421: 25.3; desktop.el: Steal lock when no living "emacs" process owns it Date: Sun, 11 Feb 2018 19:18:01 +0200 Message-ID: <837erj1m46.fsf@gnu.org> References: <871shram2i.fsf@gmail.com> <83mv0f1q6t.fsf@gnu.org> <87r2prpl05.fsf@gmail.com> <87zi4fa4ft.fsf@users.sourceforge.net> <838tbz1o8k.fsf@gnu.org> <87mv0f5urq.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1518369473 9982 195.159.176.226 (11 Feb 2018 17:17:53 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 11 Feb 2018 17:17:53 +0000 (UTC) Cc: 30421@debbugs.gnu.org, npostavs@users.sourceforge.net To: Pierre Neidhardt Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Feb 11 18:17:48 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ekvFS-0008Eh-3S for geb-bug-gnu-emacs@m.gmane.org; Sun, 11 Feb 2018 18:17:06 +0100 Original-Received: from localhost ([::1]:33699 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ekvHT-0007rc-ID for geb-bug-gnu-emacs@m.gmane.org; Sun, 11 Feb 2018 12:19:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50442) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ekvHN-0007qS-CC for bug-gnu-emacs@gnu.org; Sun, 11 Feb 2018 12:19:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ekvHK-0003sE-Nh for bug-gnu-emacs@gnu.org; Sun, 11 Feb 2018 12:19:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58883) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ekvHK-0003rR-K4 for bug-gnu-emacs@gnu.org; Sun, 11 Feb 2018 12:19:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ekvHK-0004DW-AK for bug-gnu-emacs@gnu.org; Sun, 11 Feb 2018 12:19:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Feb 2018 17:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30421 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30421-submit@debbugs.gnu.org id=B30421.151836950616169 (code B ref 30421); Sun, 11 Feb 2018 17:19:02 +0000 Original-Received: (at 30421) by debbugs.gnu.org; 11 Feb 2018 17:18:26 +0000 Original-Received: from localhost ([127.0.0.1]:38547 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ekvGj-0004Ci-RG for submit@debbugs.gnu.org; Sun, 11 Feb 2018 12:18:25 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:58860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ekvGi-0004CV-8d for 30421@debbugs.gnu.org; Sun, 11 Feb 2018 12:18:24 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ekvGa-000273-7A for 30421@debbugs.gnu.org; Sun, 11 Feb 2018 12:18:18 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57372) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ekvGa-00026z-3Q; Sun, 11 Feb 2018 12:18:16 -0500 Original-Received: from [176.228.60.248] (port=1206 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ekvGZ-0000aa-Fe; Sun, 11 Feb 2018 12:18:15 -0500 In-reply-to: <87mv0f5urq.fsf@gmail.com> (message from Pierre Neidhardt on Sun, 11 Feb 2018 17:57:29 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:143153 Archived-At: > From: Pierre Neidhardt > Cc: Noam Postavsky , 30421@debbugs.gnu.org > Date: Sun, 11 Feb 2018 17:57:29 +0100 > > Setting `desktop-load-locked-desktop' works _only if_ I know there is no > other emacs (daemon or not) owning the lock. We still have a conflict > otherwise. > > Hence my suggested patch. > > It won't work in the scenario Eli mentioned, but I'm not sure how > relevant that is. Isn't better than than generating conflict with local > instance of Emacs? No, I don't think so. Why cannot you simply delete the lock file? After all, a crashing Emacs should be a somewhat rare phenomenon... Alternatively, don't read desktop until the first client connects, i.e. do that in a after-make-frame-functions hook. Reading desktop in daemon mode is problematic for other reasons as well: e.g., GUI frames cannot be created and GUI features cannot be turned on.