all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: 30491@debbugs.gnu.org
Subject: bug#30491: 26.0; (elisp) `Profiling'
Date: Sat, 17 Feb 2018 12:06:06 +0200	[thread overview]
Message-ID: <837ercc4mp.fsf@gnu.org> (raw)
In-Reply-To: <d0e242c5-d77b-407e-a2a9-f60b3a48fcef@default> (message from Drew Adams on Fri, 16 Feb 2018 10:11:59 -0800 (PST))

> Date: Fri, 16 Feb 2018 10:11:59 -0800 (PST)
> From: Drew Adams <drew.adams@oracle.com>
> 
> 1. "how much resource" is not good English.  How much of a given
>    resource or how many resources, not how much resource.  "Resource" is
>    a countable noun.
> 
> 2. "See the functions 'benchmark-run' and 'benchmark-run-compiled'".
>    Those are macros, not functions.  And it should probably mention
>    command `benchmark'.

I fixed those.

> 3. The node should say something about library `elp', or it should not
>    mention it.  The approach should be similar to what is said about
>    library `benchmark.el', at a minimum.

Done.

> 4. A simple example of using the profiler commands would be welcome.

Not sure what example you had in mind.  The text mentions 3 profiler
commands to invoke, and describes the resulting profile.  What would
the example include, besides just "M-x profile-start" etc., which
sounds redundant?

> Also, some brief comparison of profile, elp, and benchmark could be helpful: what are their particular purposes, strengths, etc.

I think this was already clear from the text: e.g., benchmark only
measures the total execution time of a form, it doesn't produce any
insights on the distribution of that time between the form's
components.  I added more text to make some differences more clear.

Thanks.





  parent reply	other threads:[~2018-02-17 10:06 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-16 18:11 bug#30491: 26.0; (elisp) `Profiling' Drew Adams
2018-02-16 18:15 ` Drew Adams
2018-02-17 10:06 ` Eli Zaretskii [this message]
     [not found] <<d0e242c5-d77b-407e-a2a9-f60b3a48fcef@default>
     [not found] ` <<837ercc4mp.fsf@gnu.org>
2018-02-17 15:45   ` Drew Adams
2018-02-17 16:16     ` Noam Postavsky
2018-02-17 16:24     ` Eli Zaretskii
2018-02-18 17:36       ` Drew Adams
2018-02-20 18:26         ` Drew Adams
2021-10-23 17:01       ` Stefan Kangas
2021-10-23 18:18         ` bug#30491: [External] : " Drew Adams
2021-10-23 18:36           ` Stefan Kangas
2021-10-23 19:06             ` Drew Adams
2021-10-23 19:14             ` Eli Zaretskii
2021-10-23 19:38               ` Drew Adams
2021-10-24  5:49                 ` Eli Zaretskii
2021-10-23 21:13               ` Stefan Kangas
2021-10-23 19:12           ` Eli Zaretskii
2018-02-18 15:52     ` Drew Adams
2018-02-18 16:22       ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=837ercc4mp.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=30491@debbugs.gnu.org \
    --cc=drew.adams@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.