all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: jostein@kjonigsen.net
Cc: vladimir@thecybershadow.net, emacs-devel@gnu.org
Subject: Re: Support variable-unquoting syntax in bat-mode
Date: Thu, 15 Mar 2018 15:25:04 +0200	[thread overview]
Message-ID: <837eqdqxn3.fsf@gnu.org> (raw)
In-Reply-To: <1521060533.1176720.1303384360.4AF7D686@webmail.messagingengine.com> (message from Jostein Kjønigsen on Wed, 14 Mar 2018 21:48:53 +0100)

> From: Jostein Kjønigsen <jostein@secure.kjonigsen.net>
> Cc: emacs-devel@gnu.org, vladimir@thecybershadow.net
> Date: Wed, 14 Mar 2018 21:48:53 +0100
> 
>  --- lisp/progmodes/bat-mode.el~ 2018-01-03 13:09:15.000000000 +0200
>  +++ lisp/progmodes/bat-mode.el 2018-03-14 17:10:44.238856900 +0200
>  @@ -84,6 +84,8 @@
>            . 'bat-label-face)
>          ("\\_<\\(defined\\|set\\)\\_>[ \t]*\\(\\(\\sw\\|\\s_\\)+\\)"
>            (2 font-lock-variable-name-face))
>  +        ("%~\\([1-9]\\)"
>  +         (1 font-lock-variable-name-face))
>          ("%\\([^%~ \n]+\\)%?"
>            (1 font-lock-variable-name-face))
>          ("!\\([^!%~ \n]+\\)!?"  ; delayed-expansion !variable!
> 
> That works for me, and running "make check", it seems all tests still pass.
> 
> If I were to amend this in any way, it would be extending  the range check from 0 (zero) to 9, (as opposed 1 to
> 9).
> 
> %0  is the program being executed, and in certain cases a normal parameter to extract (for instance in
> generic logging-statements).

Right, fixed to use 0 and pushed to the master branch, including a
test for this new feature.

Thanks.



      reply	other threads:[~2018-03-15 13:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-14  8:37 Support variable-unquoting syntax in bat-mode Jostein Kjønigsen
2018-03-14 14:15 ` Vladimir Panteleev
2018-03-14 16:22 ` Eli Zaretskii
2018-03-14 20:48   ` Jostein Kjønigsen
2018-03-15 13:25     ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=837eqdqxn3.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=jostein@kjonigsen.net \
    --cc=vladimir@thecybershadow.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.