From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Unnecessarily moving stiff between files considered harmful (Was: [Emacs-diffs] master b88e7c8: Make transpose-regions interactive) (Bug#30343) Date: Thu, 22 Mar 2018 09:15:03 +0200 Message-ID: <837eq4k2dk.fsf@gnu.org> References: <20180311105533.30002.78782@vcs0.savannah.gnu.org> <20180311105534.3DAFD23CF3@vcs0.savannah.gnu.org> <83woyiscns.fsf@gnu.org> <87po44jb7w.fsf@red-bean.com> <20180311105533.30002.78782@vcs0.savannah.gnu.org> <20180311105534.3DAFD23CF3@vcs0.savannah.gnu.org> <83woyiscns.fsf@gnu.org> <87a7v2zb27.fsf@red-bean.com> <838tallwpg.fsf@gnu.org> <87a7v0brtb.fsf@red-bean.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1521702791 16626 195.159.176.226 (22 Mar 2018 07:13:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 22 Mar 2018 07:13:11 +0000 (UTC) Cc: emacs-devel@gnu.org To: Karl Fogel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 22 08:13:07 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eyuPL-0004DV-71 for ged-emacs-devel@m.gmane.org; Thu, 22 Mar 2018 08:13:07 +0100 Original-Received: from localhost ([::1]:59160 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyuRO-0006lM-Iq for ged-emacs-devel@m.gmane.org; Thu, 22 Mar 2018 03:15:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55704) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyuRI-0006l4-30 for emacs-devel@gnu.org; Thu, 22 Mar 2018 03:15:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyuRE-0004yg-Qr for emacs-devel@gnu.org; Thu, 22 Mar 2018 03:15:08 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39873) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyuRE-0004yX-Mo; Thu, 22 Mar 2018 03:15:04 -0400 Original-Received: from [176.228.60.248] (port=3859 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eyuRD-0003RB-V6; Thu, 22 Mar 2018 03:15:04 -0400 In-reply-to: <87a7v0brtb.fsf@red-bean.com> (message from Karl Fogel on Thu, 22 Mar 2018 00:30:24 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:223906 Archived-At: > From: Karl Fogel > Date: Thu, 22 Mar 2018 00:30:24 -0500 > > > . moving code between files makes forensics harder ("git log -L" and > > its ilk become almost useless, for example) > > True. Btw, if I'm allowed a gripe: we have too much of this in our history already. Just recently I wanted to know when the assertion in set_blv_found was born, and was unable to determine this using Git, because that function was first a macro, then an inline function, and migrated between 2 or 3 files several times. I eventually had to use ChangeLog files from old Emacs releases(!) to find out the history of this single line. I'm sure Git gurus will come up with some convoluted way to do that with Git, and Magit gurus will tell that Magit already knows how to do this. But the fact that the usual tools of trade fail here is for me a clear indication that we should keep this disadvantage in mind when making such changes: there's a non-zero price here.