From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#20890: master 1233bcb: Work around GC+Cairo bug Date: Wed, 04 Apr 2018 12:08:26 +0300 Message-ID: <837epn49v9.fsf@gnu.org> References: <20180403152442.25413.61540@vcs0.savannah.gnu.org> <20180403152443.B15F6215A9@vcs0.savannah.gnu.org> <87a7ukc4zn.fsf@gmail.com> <83k1tn4h4f.fsf@gnu.org> <878ta34alh.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1522832839 21998 195.159.176.226 (4 Apr 2018 09:07:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 4 Apr 2018 09:07:19 +0000 (UTC) Cc: 20890@debbugs.gnu.org, eggert@cs.ucla.edu To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 04 11:07:15 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f3eNu-0005cN-KZ for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 Apr 2018 11:07:14 +0200 Original-Received: from localhost ([::1]:44495 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f3ePz-0002Rw-RO for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 Apr 2018 05:09:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60090) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f3ePk-0002NZ-0m for bug-gnu-emacs@gnu.org; Wed, 04 Apr 2018 05:09:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f3ePe-00028P-0y for bug-gnu-emacs@gnu.org; Wed, 04 Apr 2018 05:09:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57948) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f3ePd-000284-TG for bug-gnu-emacs@gnu.org; Wed, 04 Apr 2018 05:09:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f3ePd-0001JX-LB for bug-gnu-emacs@gnu.org; Wed, 04 Apr 2018 05:09:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Apr 2018 09:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20890 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20890-submit@debbugs.gnu.org id=B20890.15228329095014 (code B ref 20890); Wed, 04 Apr 2018 09:09:01 +0000 Original-Received: (at 20890) by debbugs.gnu.org; 4 Apr 2018 09:08:29 +0000 Original-Received: from localhost ([127.0.0.1]:37612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f3eP7-0001Io-Cs for submit@debbugs.gnu.org; Wed, 04 Apr 2018 05:08:29 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:40732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f3eP5-0001Ib-Q3 for 20890@debbugs.gnu.org; Wed, 04 Apr 2018 05:08:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f3eOu-0001sS-QT for 20890@debbugs.gnu.org; Wed, 04 Apr 2018 05:08:22 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35892) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f3eOu-0001sL-MJ; Wed, 04 Apr 2018 05:08:16 -0400 Original-Received: from [176.228.60.248] (port=4375 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1f3eOu-0005ZL-58; Wed, 04 Apr 2018 05:08:16 -0400 In-reply-to: <878ta34alh.fsf@gmail.com> (message from Robert Pluim on Wed, 04 Apr 2018 10:52:42 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144879 Archived-At: > From: Robert Pluim > Cc: eggert@cs.ucla.edu, 20890@debbugs.gnu.org > Date: Wed, 04 Apr 2018 10:52:42 +0200 > > > Sorry, I don't understand: are you saying that you still get crashes > > inside ftfont_close, after the above commit? If so, can you please > > show the backtrace? > > Yes. > > > (Let's please continue discussing this in the bug report, not here.) > > Moved there. Backtrace: > > Thread 1 "emacs" received signal SIGSEGV, Segmentation fault. > 0x00007ffff1f87c68 in FT_List_Find () from /usr/lib/x86_64-linux-gnu/libfreetype.so.6 > (gdb) bt > #0 0x00007ffff1f87c68 in FT_List_Find () from /usr/lib/x86_64-linux-gnu/libfreetype.so.6 > #1 0x00007ffff1f87ecf in FT_Done_Size () from /usr/lib/x86_64-linux-gnu/libfreetype.so.6 > #2 0x00000000005d5484 in ftcrfont_close (font=0x35fdf60) at ftcrfont.c:176 > #3 0x00000000005502db in cleanup_vector (vector=vector@entry=0x35fdf60) at alloc.c:3194 This is not in ftfont_close, this is in ftcrfont_close. If you can tell why FT_List_Find crashes, in terms of Emacs variables and data structures, maybe we can figure out what is going on here. But in any case, I think we should put the same workaround in ftcrfont_close as we did in ftfont_close, because the former calls the latter, and we then risk the situation where we only half-close the font when ftcrfont_close is called from GC. Thanks.