From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#31676: 27.0.50; More helpful error message for unescaped character literals Date: Fri, 08 Jun 2018 17:51:09 +0300 Message-ID: <837en9uyaq.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1528469418 7437 195.159.176.226 (8 Jun 2018 14:50:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 8 Jun 2018 14:50:18 +0000 (UTC) Cc: larsi@gnus.org, 31676@debbugs.gnu.org To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 08 16:50:14 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRIiP-0001fx-Fp for geb-bug-gnu-emacs@m.gmane.org; Fri, 08 Jun 2018 16:50:09 +0200 Original-Received: from localhost ([::1]:36321 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fRIkU-0005xc-Km for geb-bug-gnu-emacs@m.gmane.org; Fri, 08 Jun 2018 10:52:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59611) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fRIkJ-0005vf-Os for bug-gnu-emacs@gnu.org; Fri, 08 Jun 2018 10:52:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fRIkE-0003ut-Sy for bug-gnu-emacs@gnu.org; Fri, 08 Jun 2018 10:52:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60103) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fRIkE-0003uk-OW for bug-gnu-emacs@gnu.org; Fri, 08 Jun 2018 10:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fRIkE-0006vd-GT for bug-gnu-emacs@gnu.org; Fri, 08 Jun 2018 10:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Jun 2018 14:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31676 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31676-submit@debbugs.gnu.org id=B31676.152846948926589 (code B ref 31676); Fri, 08 Jun 2018 14:52:02 +0000 Original-Received: (at 31676) by debbugs.gnu.org; 8 Jun 2018 14:51:29 +0000 Original-Received: from localhost ([127.0.0.1]:39767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRIjh-0006um-4Q for submit@debbugs.gnu.org; Fri, 08 Jun 2018 10:51:29 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:40245) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRIjg-0006uZ-5G for 31676@debbugs.gnu.org; Fri, 08 Jun 2018 10:51:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fRIjW-0003WL-6Y for 31676@debbugs.gnu.org; Fri, 08 Jun 2018 10:51:23 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58979) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fRIjW-0003WF-2h; Fri, 08 Jun 2018 10:51:18 -0400 Original-Received: from [176.228.60.248] (port=1597 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fRIjU-0001zI-Aq; Fri, 08 Jun 2018 10:51:17 -0400 In-reply-to: (message from Philipp Stephani on Sat, 2 Jun 2018 12:00:26 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147176 Archived-At: > Date: Sat, 2 Jun 2018 12:00:26 +0200 > Cc: 31676@debbugs.gnu.org > > Sounds reasonable, here's a patch. > > From 4bd8348753980be95dc4bcba47e52f7f79255fb6 Mon Sep 17 00:00:00 2001 > From: Philipp Stephani > Date: Sat, 2 Jun 2018 11:59:02 +0200 > Subject: [PATCH] Make warning about unescaped character literals more helpful. > > See Bug#31676. > > * src/lread.c (Flread_unescaped_character_literals_warning): New > defun. > (load_warn_unescaped_character_literals): Use it. > (syms_of_lread): Define new defun. Unintern internal > variable, which is not used any more outside of lread.c > > * lisp/emacs-lisp/bytecomp.el (byte-compile-from-buffer): Use new > defun. > > * test/src/lread-tests.el (lread-tests--unescaped-char-literals): > test/lisp/emacs-lisp/bytecomp-tests.el > (bytecomp-tests--unescaped-char-literals): Adapt unit tests. Sounds okay, but can you tell why you implemented lread--unescaped-character-literals in C? If that's because you need to call it from load_warn_unescaped_character_literals, then C functions can call Lisp functions with no problems, we have several examples of that in the sources. AFAICT, the C implementation is just a "transliteration" of straightforward Lisp code, so it reads strange.