From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] New option to make C-x 4 a use file-less ChangeLog buffers (was Re: git history tracking across renames (and emacs support)) Date: Sat, 21 Jul 2018 13:42:40 +0300 Message-ID: <837elozx7j.fsf@gnu.org> References: <86wp12qtgo.fsf@dod.no> <83tvw6chqv.fsf@gnu.org> <86shbprix7.fsf_-_@dod.no> <838t6jgl1k.fsf@gnu.org> <601m6cc6.fsf@lifelogs.com> <83o9fefnv9.fsf@gnu.org> <83in5lg4ol.fsf@gnu.org> <83efg9fxnj.fsf@gnu.org> <838t6hfa4h.fsf@gnu.org> <87h8l4lt9q.fsf@gmail.com> <831sc8fttu.fsf@gnu.org> <87sh4lwwg6.fsf_-_@gmail.com> <83r2k389j9.fsf@gnu.org> <87zhyqbx7s.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1532169656 11401 195.159.176.226 (21 Jul 2018 10:40:56 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 21 Jul 2018 10:40:56 +0000 (UTC) Cc: tzz@lifelogs.com, larsi@gnus.org, cpitclaudel@gmail.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 21 12:40:52 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgpJi-0002rz-CR for ged-emacs-devel@m.gmane.org; Sat, 21 Jul 2018 12:40:50 +0200 Original-Received: from localhost ([::1]:51505 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fgpLp-0002nV-7f for ged-emacs-devel@m.gmane.org; Sat, 21 Jul 2018 06:43:01 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40206) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fgpLa-0002nB-Sn for emacs-devel@gnu.org; Sat, 21 Jul 2018 06:42:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fgpLX-0002Um-Bh for emacs-devel@gnu.org; Sat, 21 Jul 2018 06:42:46 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56358) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fgpLT-0002U3-4Y; Sat, 21 Jul 2018 06:42:39 -0400 Original-Received: from [176.228.60.248] (port=2731 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fgpLS-0003Qc-2M; Sat, 21 Jul 2018 06:42:38 -0400 In-reply-to: <87zhyqbx7s.fsf@gmail.com> (message from =?utf-8?B?Sm/Do28g?= =?utf-8?B?VMOhdm9yYQ==?= on Tue, 17 Jul 2018 00:02:47 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:227610 Archived-At: > From: João Távora > Cc: monnier@iro.umontreal.ca, larsi@gnus.org, tzz@lifelogs.com, emacs-devel@gnu.org, cpitclaudel@gmail.com > Date: Tue, 17 Jul 2018 00:02:47 +0100 > > > Thanks. I didn't forget about this and didn't lose it. I'm just a > > bit busy these days, and may need a couple more days before I get to > > reviewing this. I'm saving Stefan's comments and your responses for > > that time. > > > > Stay tuned. > > No worries. When you do get around to it, have a look at the patch I > attach to this mail instead, because it integrates a few of Stefan's > suggestions (the part we don't yet agree is how, if at all, to add > uniquify.el into the equation...). Looks reasonable, thanks. > +(defcustom add-log-use-pseudo-changelog t > + "If non-nil, don't create ChangeLog files for log entries." > + :type :boolean) I frequently find that what we say in the doc string is a very good hint on how to name the variable. So how about add-log-don't-create-change-log-file instead? Also, this needs a :version tag. > +(defun add-log--pseudo-changelog-buffer-name (changelog-file-name) > + "Compute suitable name for a pseudo-ChangeLog buffer." > + (format "*changes to %s*" > + (abbreviate-file-name > + (file-name-directory changelog-file-name)))) Would the name of the buffer be something like "*changes to ChangeLog*"? That's awkward, IMO. How about just "*ChangeLog*" instead? The above are minor nits, so what else is left that needs to be agreed upon? Thanks.