From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#32257: 26.1; read-multiple-choice inf loops on mouse clicks Date: Fri, 27 Jul 2018 16:50:02 +0300 Message-ID: <837elgss8l.fsf@gnu.org> References: <87muug4z52.fsf@gmail.com> <87y3dy3i05.fsf@gmail.com> <83muudrqol.fsf@gnu.org> <83effosvx2.fsf@gnu.org> <87r2jo3l0w.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1532699349 19212 195.159.176.226 (27 Jul 2018 13:49:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 27 Jul 2018 13:49:09 +0000 (UTC) Cc: andrewjmoreton@gmail.com, 32257@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 27 15:49:05 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fj37B-0004tU-2Y for geb-bug-gnu-emacs@m.gmane.org; Fri, 27 Jul 2018 15:49:05 +0200 Original-Received: from localhost ([::1]:41424 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fj39H-00045A-VO for geb-bug-gnu-emacs@m.gmane.org; Fri, 27 Jul 2018 09:51:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53008) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fj399-000452-M2 for bug-gnu-emacs@gnu.org; Fri, 27 Jul 2018 09:51:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fj394-0002vI-KA for bug-gnu-emacs@gnu.org; Fri, 27 Jul 2018 09:51:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54719) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fj394-0002ur-Ej for bug-gnu-emacs@gnu.org; Fri, 27 Jul 2018 09:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fj394-00067r-8O for bug-gnu-emacs@gnu.org; Fri, 27 Jul 2018 09:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Jul 2018 13:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32257 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32257-submit@debbugs.gnu.org id=B32257.153269941523483 (code B ref 32257); Fri, 27 Jul 2018 13:51:02 +0000 Original-Received: (at 32257) by debbugs.gnu.org; 27 Jul 2018 13:50:15 +0000 Original-Received: from localhost ([127.0.0.1]:59737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fj38I-00066h-K4 for submit@debbugs.gnu.org; Fri, 27 Jul 2018 09:50:14 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:33636) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fj38G-00066S-VO for 32257@debbugs.gnu.org; Fri, 27 Jul 2018 09:50:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fj386-0001XQ-L4 for 32257@debbugs.gnu.org; Fri, 27 Jul 2018 09:50:07 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59881) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fj386-0001X9-G8; Fri, 27 Jul 2018 09:50:02 -0400 Original-Received: from [176.228.60.248] (port=3922 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fj385-0004Zd-UJ; Fri, 27 Jul 2018 09:50:02 -0400 In-reply-to: <87r2jo3l0w.fsf@gmail.com> (message from Noam Postavsky on Fri, 27 Jul 2018 08:45:03 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149017 Archived-At: > From: Noam Postavsky > Cc: Andy Moreton , 32257@debbugs.gnu.org > Date: Fri, 27 Jul 2018 08:45:03 -0400 > > Eli Zaretskii writes: > > >> From: Andy Moreton > >> Date: Fri, 27 Jul 2018 12:35:27 +0100 > >> > >> > If we want this change on emacs-26, we should carefully audit all the > >> > other users of rmc.el > > What should we check for though? Anything that read-event handles differently from read-char. Maybe a good starting point is to compile a list of the differences in behavior between the two. > >> read-multiple choice only has two callers (`nsm-query-user' and > >> `message-fix-before-sending') in both master and emacs-26. > > > > In Emacs, yes. But what about the world out there? > > I expect all the callers out in the world will exhibit the same bug. What about the features they expect? > At any rate, I don't see a way of fixing it in the caller, short of > temporarily fsetting read-char into read-event. If there's no better idea, we could copy read-multiple-choice into nsm.el and replace read-char with read-event there. But maybe there are more elegant ideas. > Also, read-multiple-choice is new in Emacs 26, so it seems to me we > should rather fix it in 26.2. I agree, I just am not convince that replacing read-char with read-event is the right fix.