* bug#32849: 26.1; xref-marker-ring-length user option doesn't have setter @ 2018-09-26 23:14 Allen Li 2018-09-27 8:24 ` Eli Zaretskii 0 siblings, 1 reply; 7+ messages in thread From: Allen Li @ 2018-09-26 23:14 UTC (permalink / raw) To: 32849 The xref-marker-ring-length user option doesn't have a setter, so customizing it will not affect xref--marker-ring, except if/when user customizations are loaded in a new Emacs process before xref is loaded. Customizations after xref is loaded will have no effect. In GNU Emacs 26.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.24), modified by Debian Windowing system distributor 'The X.Org Foundation', version 11.0.11906000 System Description: Debian GNU/Linux rodete (upgraded from: Ubuntu 14.04 LTS) ^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#32849: 26.1; xref-marker-ring-length user option doesn't have setter 2018-09-26 23:14 bug#32849: 26.1; xref-marker-ring-length user option doesn't have setter Allen Li @ 2018-09-27 8:24 ` Eli Zaretskii 2018-10-25 3:30 ` Allen Li 0 siblings, 1 reply; 7+ messages in thread From: Eli Zaretskii @ 2018-09-27 8:24 UTC (permalink / raw) To: Allen Li; +Cc: 32849 > From: Allen Li <darkfeline@felesatra.moe> > Date: Wed, 26 Sep 2018 16:14:15 -0700 > > The xref-marker-ring-length user option doesn't have a setter, so > customizing it will not affect xref--marker-ring, except if/when user > customizations are loaded in a new Emacs process before xref is loaded. > Customizations after xref is loaded will have no effect. I think the setter should use ring-extend to enlarge the ring, and some custom code using ring-remove to make the ring smaller. Would you like to submit a patch along those lines? Thanks. ^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#32849: 26.1; xref-marker-ring-length user option doesn't have setter 2018-09-27 8:24 ` Eli Zaretskii @ 2018-10-25 3:30 ` Allen Li 2018-10-27 9:57 ` Eli Zaretskii 2018-10-28 18:32 ` Noam Postavsky 0 siblings, 2 replies; 7+ messages in thread From: Allen Li @ 2018-10-25 3:30 UTC (permalink / raw) To: eliz; +Cc: 32849 [-- Attachment #1: Type: text/plain, Size: 1070 bytes --] Patches attached. Of note: I added a ring-resize function. I wrote tests with names function-to-test/case-tested. I'm not sure if this violates style policies for tests. It seems like existing code tests multiple cases in a single test, but I find separate tests easier to understand when they regress. The / makes the test names easier to read. I based this off of 26 (as I think this is a minor bugfix/feature add). On Thu, Sep 27, 2018 at 2:24 AM Eli Zaretskii <eliz@gnu.org> wrote: > > > From: Allen Li <darkfeline@felesatra.moe> > > Date: Wed, 26 Sep 2018 16:14:15 -0700 > > > > The xref-marker-ring-length user option doesn't have a setter, so > > customizing it will not affect xref--marker-ring, except if/when user > > customizations are loaded in a new Emacs process before xref is loaded. > > Customizations after xref is loaded will have no effect. > > I think the setter should use ring-extend to enlarge the ring, and > some custom code using ring-remove to make the ring smaller. > > Would you like to submit a patch along those lines? > > Thanks. [-- Attachment #2: 0002-Add-setter-for-xref-marker-ring-length.patch --] [-- Type: text/x-patch, Size: 2301 bytes --] From ec3e24819c5e2ec2df1f51bd3cb70ac4e598b9d6 Mon Sep 17 00:00:00 2001 From: Allen Li <darkfeline@felesatra.moe> Date: Wed, 24 Oct 2018 20:48:15 -0600 Subject: [PATCH 2/2] Add setter for xref-marker-ring-length * etc/NEWS: Document change * lisp/progmodes/xref.el (xref-marker-ring-length): Add setter --- etc/NEWS | 7 +++++++ lisp/progmodes/xref.el | 16 ++++++++++++++-- 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index c67b13205c..f9a9fa6afc 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -113,6 +113,13 @@ option 'vc-hg-symbolic-revision-styles' to the value '("{rev}")'. --- ** shadowfile.el has been rewritten to support Tramp file names. +** xref + ++++ +*** Setter added for 'xref-marker-ring-length'. +Previously, setting 'xref-marker-ring-length' would only take effect +if set before `xref.el` was loaded. + \f * New Modes and Packages in Emacs 26.2 diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el index abb2a93425..eaa4014145 100644 --- a/lisp/progmodes/xref.el +++ b/lisp/progmodes/xref.el @@ -317,8 +317,12 @@ xref--search-property ;;; Marker stack (M-. pushes, M-, pops) (defcustom xref-marker-ring-length 16 - "Length of the xref marker ring." - :type 'integer) + "Length of the xref marker ring. +If this variable is not set through Customize, you must call +‘xref-set-marker-ring-length’ for changes to take effect." + :type 'integer + :initialize #'custom-initialize-default + :set #'xref-set-marker-ring-length) (defcustom xref-prompt-for-identifier '(not xref-find-definitions xref-find-definitions-other-window @@ -354,6 +358,14 @@ xref-after-return-hook (defvar xref--marker-ring (make-ring xref-marker-ring-length) "Ring of markers to implement the marker stack.") +(defun xref-set-marker-ring-length (var val) + "Set ‘xref-marker-ring-length’. +VAR is the symbol ‘xref-marker-ring-length’ and VAL is the new +value." + (set-default var val) + (if (ring-p xref--marker-ring) + (ring-resize xref--marker-ring val))) + (defun xref-push-marker-stack (&optional m) "Add point M (defaults to `point-marker') to the marker stack." (ring-insert xref--marker-ring (or m (point-marker)))) -- 2.19.1.568.g152ad8e336-goog [-- Attachment #3: 0001-Add-ring-resize-function.patch --] [-- Type: text/x-patch, Size: 5026 bytes --] From 98138a5e9cf2afaae5ec55264daf304201b4b50d Mon Sep 17 00:00:00 2001 From: Allen Li <darkfeline@felesatra.moe> Date: Wed, 24 Oct 2018 20:44:01 -0600 Subject: [PATCH 1/2] Add ring-resize function * doc/lispref/sequences.texi (Rings): Document new function * etc/NEWS: Document new function * lisp/emacs-lisp/ring.el (ring-resize): New function * test/lisp/emacs-lisp/ring-tests.el (ring-test-ring-resize): New tests --- doc/lispref/sequences.texi | 5 ++++ etc/NEWS | 4 ++++ lisp/emacs-lisp/ring.el | 33 +++++++++++++++++--------- test/lisp/emacs-lisp/ring-tests.el | 37 ++++++++++++++++++++++++++++++ 4 files changed, 68 insertions(+), 11 deletions(-) diff --git a/doc/lispref/sequences.texi b/doc/lispref/sequences.texi index 51d724cb1d..233b64d491 100644 --- a/doc/lispref/sequences.texi +++ b/doc/lispref/sequences.texi @@ -1771,6 +1771,11 @@ Rings room for the inserted element. @end defun +@defun ring-resize ring size +Set the size of @var{ring} to @var{size}. If the new size is smaller, +then the oldest items in the ring are discarded. +@end defun + @cindex fifo data structure If you are careful not to exceed the ring size, you can use the ring as a first-in-first-out queue. For example: diff --git a/etc/NEWS b/etc/NEWS index dfafe7c5c9..c67b13205c 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -161,6 +161,10 @@ To cater to use cases where comments and strings are to be ignored when looking for a list, the function 'list-at-point' now takes an optional argument to do so. ++++ +** New function 'ring-resize'. +'ring-resize' can be used to grow or shrink a ring. + \f * Changes in Emacs 26.2 on Non-Free Operating Systems diff --git a/lisp/emacs-lisp/ring.el b/lisp/emacs-lisp/ring.el index 312df6b2de..1b36811f9e 100644 --- a/lisp/emacs-lisp/ring.el +++ b/lisp/emacs-lisp/ring.el @@ -189,17 +189,28 @@ ring-previous (defun ring-extend (ring x) "Increase the size of RING by X." (when (and (integerp x) (> x 0)) - (let* ((hd (car ring)) - (length (ring-length ring)) - (size (ring-size ring)) - (old-vec (cddr ring)) - (new-vec (make-vector (+ size x) nil))) - (setcdr ring (cons length new-vec)) - ;; If the ring is wrapped, the existing elements must be written - ;; out in the right order. - (dotimes (j length) - (aset new-vec j (aref old-vec (mod (+ hd j) size)))) - (setcar ring 0)))) + (ring-resize ring (+ x (ring-size ring))))) + +(defun ring-resize (ring size) + "Set the size of RING to SIZE. +If the new size is smaller, then the oldest items in the ring are +discarded." + (when (integerp size) + (let ((length (ring-length ring)) + (new-vec (make-vector size nil))) + (if (= length 0) + (setcdr ring (cons 0 new-vec)) + (let* ((hd (car ring)) + (old-size (ring-size ring)) + (old-vec (cddr ring)) + (copy-length (min size length)) + (copy-hd (mod (+ hd (- length copy-length)) length))) + (setcdr ring (cons copy-length new-vec)) + ;; If the ring is wrapped, the existing elements must be written + ;; out in the right order. + (dotimes (j copy-length) + (aset new-vec j (aref old-vec (mod (+ copy-hd j) old-size)))) + (setcar ring 0)))))) (defun ring-insert+extend (ring item &optional grow-p) "Like `ring-insert', but if GROW-P is non-nil, then enlarge ring. diff --git a/test/lisp/emacs-lisp/ring-tests.el b/test/lisp/emacs-lisp/ring-tests.el index 0b4e3d9a69..ea78895b04 100644 --- a/test/lisp/emacs-lisp/ring-tests.el +++ b/test/lisp/emacs-lisp/ring-tests.el @@ -162,6 +162,43 @@ (should (= (ring-size ring) 5)) (should (equal (ring-elements ring) '(3 2 1))))) +(ert-deftest ring-test-ring-resize/grow () + (let ((ring (make-ring 3))) + (ring-insert ring 1) + (ring-insert ring 2) + (ring-insert ring 3) + (ring-resize ring 5) + (should (= (ring-size ring) 5)) + (should (equal (ring-elements ring) '(3 2 1))))) + +(ert-deftest ring-test-ring-resize/grow-empty () + (let ((ring (make-ring 3))) + (ring-resize ring 5) + (should (= (ring-size ring) 5)) + (should (equal (ring-elements ring) '())))) + +(ert-deftest ring-test-ring-resize/grow-wrapped-ring () + (let ((ring (make-ring 3))) + (ring-insert ring 1) + (ring-insert ring 2) + (ring-insert ring 3) + (ring-insert ring 4) + (ring-insert ring 5) + (ring-resize ring 5) + (should (= (ring-size ring) 5)) + (should (equal (ring-elements ring) '(5 4 3))))) + +(ert-deftest ring-test-ring-resize/shrink () + (let ((ring (make-ring 5))) + (ring-insert ring 1) + (ring-insert ring 2) + (ring-insert ring 3) + (ring-insert ring 4) + (ring-insert ring 5) + (ring-resize ring 3) + (should (= (ring-size ring) 3)) + (should (equal (ring-elements ring) '(5 4 3))))) + (ert-deftest ring-tests-insert () (let ((ring (make-ring 2))) (ring-insert+extend ring :a) -- 2.19.1.568.g152ad8e336-goog ^ permalink raw reply related [flat|nested] 7+ messages in thread
* bug#32849: 26.1; xref-marker-ring-length user option doesn't have setter 2018-10-25 3:30 ` Allen Li @ 2018-10-27 9:57 ` Eli Zaretskii 2018-11-09 7:01 ` Allen Li 2018-10-28 18:32 ` Noam Postavsky 1 sibling, 1 reply; 7+ messages in thread From: Eli Zaretskii @ 2018-10-27 9:57 UTC (permalink / raw) To: Allen Li; +Cc: 32849 > From: Allen Li <darkfeline@felesatra.moe> > Date: Wed, 24 Oct 2018 21:30:51 -0600 > Cc: 32849@debbugs.gnu.org > > Patches attached. Thanks. Please see a few minor comments below. > I wrote tests with names function-to-test/case-tested. I'm not sure > if this violates style policies for tests. It seems like existing > code tests multiple cases in a single test, but I find separate tests > easier to understand when they regress. The / makes the test names > easier to read. I don't see any problem with this, we don't have style policy that disallows such style, AFAIK. > I based this off of 26 (as I think this is a minor bugfix/feature add). Hmm... I think we should install this on master, not on emacs-26, as the problem is not serious enough. > +** xref > + > ++++ > +*** Setter added for 'xref-marker-ring-length'. This heading is not on the user level, it's on the implementation level. I'd suggest to use this instead: You can now change 'xref-marker-ring-length' after 'xref.el' is loaded. > +if set before `xref.el` was loaded. Please use quoting 'like this' in NEWS and in comments. > (defcustom xref-marker-ring-length 16 > - "Length of the xref marker ring." > - :type 'integer) > + "Length of the xref marker ring. > +If this variable is not set through Customize, you must call > +‘xref-set-marker-ring-length’ for changes to take effect." I guess you copy-pasted the last line from the *Help* buffer, or you have electric-quotes turned on, because it uses the wrong quote characters; in doc strings, please quote `like this' instead. > +(defun xref-set-marker-ring-length (var val) > + "Set ‘xref-marker-ring-length’. > +VAR is the symbol ‘xref-marker-ring-length’ and VAL is the new Same here. ^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#32849: 26.1; xref-marker-ring-length user option doesn't have setter 2018-10-27 9:57 ` Eli Zaretskii @ 2018-11-09 7:01 ` Allen Li 2018-11-10 9:47 ` Eli Zaretskii 0 siblings, 1 reply; 7+ messages in thread From: Allen Li @ 2018-11-09 7:01 UTC (permalink / raw) To: eliz; +Cc: 32849 [-- Attachment #1: Type: text/plain, Size: 192 bytes --] On Sat, Oct 27, 2018 at 2:57 AM Eli Zaretskii <eliz@gnu.org> wrote: > Thanks. Please see a few minor comments below. Thanks for your comments. I have attached new patches based off master. [-- Attachment #2: 0001-Add-ring-resize-function.patch --] [-- Type: text/x-patch, Size: 4935 bytes --] From 73f19816e587ad1214f91f2f8880da4ae495b2ee Mon Sep 17 00:00:00 2001 From: Allen Li <darkfeline@felesatra.moe> Date: Wed, 24 Oct 2018 20:44:01 -0600 Subject: [PATCH 1/2] Add ring-resize function * doc/lispref/sequences.texi (Rings): Document new function * etc/NEWS: Document new function * lisp/emacs-lisp/ring.el (ring-resize): New function * test/lisp/emacs-lisp/ring-tests.el (ring-test-ring-resize): New tests --- doc/lispref/sequences.texi | 5 ++++ etc/NEWS | 4 ++++ lisp/emacs-lisp/ring.el | 33 +++++++++++++++++--------- test/lisp/emacs-lisp/ring-tests.el | 37 ++++++++++++++++++++++++++++++ 4 files changed, 68 insertions(+), 11 deletions(-) diff --git a/doc/lispref/sequences.texi b/doc/lispref/sequences.texi index 554716084e..955ad669b8 100644 --- a/doc/lispref/sequences.texi +++ b/doc/lispref/sequences.texi @@ -1777,6 +1777,11 @@ Rings room for the inserted element. @end defun +@defun ring-resize ring size +Set the size of @var{ring} to @var{size}. If the new size is smaller, +then the oldest items in the ring are discarded. +@end defun + @cindex fifo data structure If you are careful not to exceed the ring size, you can use the ring as a first-in-first-out queue. For example: diff --git a/etc/NEWS b/etc/NEWS index 29bbde9395..c39303dbc0 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1218,6 +1218,10 @@ to mean that it is not known whether DST is in effect. 'json-insert', 'json-parse-string', and 'json-parse-buffer'. These are implemented in C using the Jansson library. ++++ +** New function 'ring-resize'. +'ring-resize' can be used to grow or shrink a ring. + ** Mailcap --- diff --git a/lisp/emacs-lisp/ring.el b/lisp/emacs-lisp/ring.el index 312df6b2de..1b36811f9e 100644 --- a/lisp/emacs-lisp/ring.el +++ b/lisp/emacs-lisp/ring.el @@ -189,17 +189,28 @@ ring-previous (defun ring-extend (ring x) "Increase the size of RING by X." (when (and (integerp x) (> x 0)) - (let* ((hd (car ring)) - (length (ring-length ring)) - (size (ring-size ring)) - (old-vec (cddr ring)) - (new-vec (make-vector (+ size x) nil))) - (setcdr ring (cons length new-vec)) - ;; If the ring is wrapped, the existing elements must be written - ;; out in the right order. - (dotimes (j length) - (aset new-vec j (aref old-vec (mod (+ hd j) size)))) - (setcar ring 0)))) + (ring-resize ring (+ x (ring-size ring))))) + +(defun ring-resize (ring size) + "Set the size of RING to SIZE. +If the new size is smaller, then the oldest items in the ring are +discarded." + (when (integerp size) + (let ((length (ring-length ring)) + (new-vec (make-vector size nil))) + (if (= length 0) + (setcdr ring (cons 0 new-vec)) + (let* ((hd (car ring)) + (old-size (ring-size ring)) + (old-vec (cddr ring)) + (copy-length (min size length)) + (copy-hd (mod (+ hd (- length copy-length)) length))) + (setcdr ring (cons copy-length new-vec)) + ;; If the ring is wrapped, the existing elements must be written + ;; out in the right order. + (dotimes (j copy-length) + (aset new-vec j (aref old-vec (mod (+ copy-hd j) old-size)))) + (setcar ring 0)))))) (defun ring-insert+extend (ring item &optional grow-p) "Like `ring-insert', but if GROW-P is non-nil, then enlarge ring. diff --git a/test/lisp/emacs-lisp/ring-tests.el b/test/lisp/emacs-lisp/ring-tests.el index 0b4e3d9a69..9fa36aa3d3 100644 --- a/test/lisp/emacs-lisp/ring-tests.el +++ b/test/lisp/emacs-lisp/ring-tests.el @@ -162,6 +162,43 @@ (should (= (ring-size ring) 5)) (should (equal (ring-elements ring) '(3 2 1))))) +(ert-deftest ring-resize/grow () + (let ((ring (make-ring 3))) + (ring-insert ring 1) + (ring-insert ring 2) + (ring-insert ring 3) + (ring-resize ring 5) + (should (= (ring-size ring) 5)) + (should (equal (ring-elements ring) '(3 2 1))))) + +(ert-deftest ring-resize/grow-empty () + (let ((ring (make-ring 3))) + (ring-resize ring 5) + (should (= (ring-size ring) 5)) + (should (equal (ring-elements ring) '())))) + +(ert-deftest ring-resize/grow-wrapped-ring () + (let ((ring (make-ring 3))) + (ring-insert ring 1) + (ring-insert ring 2) + (ring-insert ring 3) + (ring-insert ring 4) + (ring-insert ring 5) + (ring-resize ring 5) + (should (= (ring-size ring) 5)) + (should (equal (ring-elements ring) '(5 4 3))))) + +(ert-deftest ring-resize/shrink () + (let ((ring (make-ring 5))) + (ring-insert ring 1) + (ring-insert ring 2) + (ring-insert ring 3) + (ring-insert ring 4) + (ring-insert ring 5) + (ring-resize ring 3) + (should (= (ring-size ring) 3)) + (should (equal (ring-elements ring) '(5 4 3))))) + (ert-deftest ring-tests-insert () (let ((ring (make-ring 2))) (ring-insert+extend ring :a) -- 2.19.1 [-- Attachment #3: 0002-Add-setter-for-xref-marker-ring-length.patch --] [-- Type: text/x-patch, Size: 2327 bytes --] From 643dcf2a762b34078135eb4c66a2108f2c64dfaa Mon Sep 17 00:00:00 2001 From: Allen Li <darkfeline@felesatra.moe> Date: Wed, 24 Oct 2018 20:48:15 -0600 Subject: [PATCH 2/2] Add setter for xref-marker-ring-length * etc/NEWS: Document change * lisp/progmodes/xref.el (xref-marker-ring-length): Add setter --- etc/NEWS | 5 +++++ lisp/progmodes/xref.el | 16 ++++++++++++++-- 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index c39303dbc0..203d89ee07 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -460,6 +460,11 @@ for example. This command finds definitions of the identifier at the place of a mouse click event, and is intended to be bound to a mouse event. ++++ +*** Changing 'xref-marker-ring-length' works after 'xref.el' is loaded. +Previously, setting 'xref-marker-ring-length' would only take effect +if set before 'xref.el' was loaded. + ** Ecomplete *** The ecomplete sorting has changed to a decay-based algorithm. diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el index 6b1421a6f7..3b449bf9b1 100644 --- a/lisp/progmodes/xref.el +++ b/lisp/progmodes/xref.el @@ -317,8 +317,12 @@ xref--search-property ;;; Marker stack (M-. pushes, M-, pops) (defcustom xref-marker-ring-length 16 - "Length of the xref marker ring." - :type 'integer) + "Length of the xref marker ring. +If this variable is not set through Customize, you must call +`xref-set-marker-ring-length' for changes to take effect." + :type 'integer + :initialize #'custom-initialize-default + :set #'xref-set-marker-ring-length) (defcustom xref-prompt-for-identifier '(not xref-find-definitions xref-find-definitions-other-window @@ -354,6 +358,14 @@ xref-after-return-hook (defvar xref--marker-ring (make-ring xref-marker-ring-length) "Ring of markers to implement the marker stack.") +(defun xref-set-marker-ring-length (var val) + "Set `xref-marker-ring-length'. +VAR is the symbol `xref-marker-ring-length' and VAL is the new +value." + (set-default var val) + (if (ring-p xref--marker-ring) + (ring-resize xref--marker-ring val))) + (defun xref-push-marker-stack (&optional m) "Add point M (defaults to `point-marker') to the marker stack." (ring-insert xref--marker-ring (or m (point-marker)))) -- 2.19.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* bug#32849: 26.1; xref-marker-ring-length user option doesn't have setter 2018-11-09 7:01 ` Allen Li @ 2018-11-10 9:47 ` Eli Zaretskii 0 siblings, 0 replies; 7+ messages in thread From: Eli Zaretskii @ 2018-11-10 9:47 UTC (permalink / raw) To: Allen Li; +Cc: 32849-done > From: Allen Li <darkfeline@felesatra.moe> > Date: Thu, 8 Nov 2018 23:01:21 -0800 > Cc: 32849@debbugs.gnu.org > > On Sat, Oct 27, 2018 at 2:57 AM Eli Zaretskii <eliz@gnu.org> wrote: > > Thanks. Please see a few minor comments below. > > Thanks for your comments. I have attached new patches based off master. Thanks, I pushed this to the master branch. One nit: > * doc/lispref/sequences.texi (Rings): Document new function > * etc/NEWS: Document new function > * lisp/emacs-lisp/ring.el (ring-resize): New function > * test/lisp/emacs-lisp/ring-tests.el (ring-test-ring-resize): New tests Please end each entry in the commit log with a period, as it's supposed to be one or more complete sentences. ^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#32849: 26.1; xref-marker-ring-length user option doesn't have setter 2018-10-25 3:30 ` Allen Li 2018-10-27 9:57 ` Eli Zaretskii @ 2018-10-28 18:32 ` Noam Postavsky 1 sibling, 0 replies; 7+ messages in thread From: Noam Postavsky @ 2018-10-28 18:32 UTC (permalink / raw) To: Allen Li; +Cc: 32849 Allen Li <darkfeline@felesatra.moe> writes: > I wrote tests with names function-to-test/case-tested. I'm not sure > if this violates style policies for tests. It seems like existing > code tests multiple cases in a single test, but I find separate tests > easier to understand when they regress. The / makes the test names > easier to read. > +(ert-deftest ring-test-ring-resize/grow () Like Eli mentioned, there is no policy for this, but I'd say the ring-test- prefix is redundant for test names, ring-resize/grow already has the prefix ring- to avoid nameclashes with other tests (and test namespace is separate from function namespace). ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-11-10 9:47 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-09-26 23:14 bug#32849: 26.1; xref-marker-ring-length user option doesn't have setter Allen Li 2018-09-27 8:24 ` Eli Zaretskii 2018-10-25 3:30 ` Allen Li 2018-10-27 9:57 ` Eli Zaretskii 2018-11-09 7:01 ` Allen Li 2018-11-10 9:47 ` Eli Zaretskii 2018-10-28 18:32 ` Noam Postavsky
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.