From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#32849: 26.1; xref-marker-ring-length user option doesn't have setter Date: Sat, 27 Oct 2018 12:57:47 +0300 Message-ID: <837ei3ogo4.fsf@gnu.org> References: <831s9f8i1n.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1540634325 22132 195.159.176.226 (27 Oct 2018 09:58:45 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 27 Oct 2018 09:58:45 +0000 (UTC) Cc: 32849@debbugs.gnu.org To: Allen Li Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 27 11:58:41 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGLMe-0005et-LO for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Oct 2018 11:58:40 +0200 Original-Received: from localhost ([::1]:35851 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gGLOl-0001RE-7a for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Oct 2018 06:00:51 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51118) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gGLM6-0007Hz-TJ for bug-gnu-emacs@gnu.org; Sat, 27 Oct 2018 05:58:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gGLM2-0003zD-Sz for bug-gnu-emacs@gnu.org; Sat, 27 Oct 2018 05:58:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40323) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gGLM1-0003yo-Vt for bug-gnu-emacs@gnu.org; Sat, 27 Oct 2018 05:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gGLM1-0008S1-Rw for bug-gnu-emacs@gnu.org; Sat, 27 Oct 2018 05:58:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Oct 2018 09:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32849 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32849-submit@debbugs.gnu.org id=B32849.154063427432471 (code B ref 32849); Sat, 27 Oct 2018 09:58:01 +0000 Original-Received: (at 32849) by debbugs.gnu.org; 27 Oct 2018 09:57:54 +0000 Original-Received: from localhost ([127.0.0.1]:44581 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGLLt-0008Rf-Ra for submit@debbugs.gnu.org; Sat, 27 Oct 2018 05:57:54 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:41482) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGLLs-0008RT-Ew for 32849@debbugs.gnu.org; Sat, 27 Oct 2018 05:57:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gGLLk-0003o6-1L for 32849@debbugs.gnu.org; Sat, 27 Oct 2018 05:57:47 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53681) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gGLLj-0003o0-T9; Sat, 27 Oct 2018 05:57:43 -0400 Original-Received: from [176.228.60.248] (port=4084 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gGLLj-0002Et-Fs; Sat, 27 Oct 2018 05:57:43 -0400 In-reply-to: (message from Allen Li on Wed, 24 Oct 2018 21:30:51 -0600) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:151666 Archived-At: > From: Allen Li > Date: Wed, 24 Oct 2018 21:30:51 -0600 > Cc: 32849@debbugs.gnu.org > > Patches attached. Thanks. Please see a few minor comments below. > I wrote tests with names function-to-test/case-tested. I'm not sure > if this violates style policies for tests. It seems like existing > code tests multiple cases in a single test, but I find separate tests > easier to understand when they regress. The / makes the test names > easier to read. I don't see any problem with this, we don't have style policy that disallows such style, AFAIK. > I based this off of 26 (as I think this is a minor bugfix/feature add). Hmm... I think we should install this on master, not on emacs-26, as the problem is not serious enough. > +** xref > + > ++++ > +*** Setter added for 'xref-marker-ring-length'. This heading is not on the user level, it's on the implementation level. I'd suggest to use this instead: You can now change 'xref-marker-ring-length' after 'xref.el' is loaded. > +if set before `xref.el` was loaded. Please use quoting 'like this' in NEWS and in comments. > (defcustom xref-marker-ring-length 16 > - "Length of the xref marker ring." > - :type 'integer) > + "Length of the xref marker ring. > +If this variable is not set through Customize, you must call > +‘xref-set-marker-ring-length’ for changes to take effect." I guess you copy-pasted the last line from the *Help* buffer, or you have electric-quotes turned on, because it uses the wrong quote characters; in doc strings, please quote `like this' instead. > +(defun xref-set-marker-ring-length (var val) > + "Set ‘xref-marker-ring-length’. > +VAR is the symbol ‘xref-marker-ring-length’ and VAL is the new Same here.