From: Eli Zaretskii <eliz@gnu.org>
To: Allen Li <darkfeline@felesatra.moe>
Cc: 32849@debbugs.gnu.org
Subject: bug#32849: 26.1; xref-marker-ring-length user option doesn't have setter
Date: Sat, 27 Oct 2018 12:57:47 +0300 [thread overview]
Message-ID: <837ei3ogo4.fsf@gnu.org> (raw)
In-Reply-To: <CADbSrJygDU-KUUcD8xRgP9fK_zUs6=iQTpUmtp9QLNZ3CVagHQ@mail.gmail.com> (message from Allen Li on Wed, 24 Oct 2018 21:30:51 -0600)
> From: Allen Li <darkfeline@felesatra.moe>
> Date: Wed, 24 Oct 2018 21:30:51 -0600
> Cc: 32849@debbugs.gnu.org
>
> Patches attached.
Thanks. Please see a few minor comments below.
> I wrote tests with names function-to-test/case-tested. I'm not sure
> if this violates style policies for tests. It seems like existing
> code tests multiple cases in a single test, but I find separate tests
> easier to understand when they regress. The / makes the test names
> easier to read.
I don't see any problem with this, we don't have style policy that
disallows such style, AFAIK.
> I based this off of 26 (as I think this is a minor bugfix/feature add).
Hmm... I think we should install this on master, not on emacs-26, as
the problem is not serious enough.
> +** xref
> +
> ++++
> +*** Setter added for 'xref-marker-ring-length'.
This heading is not on the user level, it's on the implementation
level. I'd suggest to use this instead:
You can now change 'xref-marker-ring-length' after 'xref.el' is loaded.
> +if set before `xref.el` was loaded.
Please use quoting 'like this' in NEWS and in comments.
> (defcustom xref-marker-ring-length 16
> - "Length of the xref marker ring."
> - :type 'integer)
> + "Length of the xref marker ring.
> +If this variable is not set through Customize, you must call
> +‘xref-set-marker-ring-length’ for changes to take effect."
I guess you copy-pasted the last line from the *Help* buffer, or you
have electric-quotes turned on, because it uses the wrong quote
characters; in doc strings, please quote `like this' instead.
> +(defun xref-set-marker-ring-length (var val)
> + "Set ‘xref-marker-ring-length’.
> +VAR is the symbol ‘xref-marker-ring-length’ and VAL is the new
Same here.
next prev parent reply other threads:[~2018-10-27 9:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 23:14 bug#32849: 26.1; xref-marker-ring-length user option doesn't have setter Allen Li
2018-09-27 8:24 ` Eli Zaretskii
2018-10-25 3:30 ` Allen Li
2018-10-27 9:57 ` Eli Zaretskii [this message]
2018-11-09 7:01 ` Allen Li
2018-11-10 9:47 ` Eli Zaretskii
2018-10-28 18:32 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837ei3ogo4.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=32849@debbugs.gnu.org \
--cc=darkfeline@felesatra.moe \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.