From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: harfbuzz 2f72162: Fix crash in the Cairo build Date: Mon, 17 Dec 2018 19:39:33 +0200 Message-ID: <837eg8dpd6.fsf@gnu.org> References: <20181214085417.15440.18845@vcs0.savannah.gnu.org> <20181214085418.6616820538@vcs0.savannah.gnu.org> <831s6kgrtj.fsf@gnu.org> <83pnu4f45d.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1545068257 31942 195.159.176.226 (17 Dec 2018 17:37:37 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 17 Dec 2018 17:37:37 +0000 (UTC) Cc: ari.roponen@gmail.com, emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 17 18:37:32 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gYwpf-00088W-RI for ged-emacs-devel@m.gmane.org; Mon, 17 Dec 2018 18:37:31 +0100 Original-Received: from localhost ([::1]:48196 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gYwrm-0003Ar-8b for ged-emacs-devel@m.gmane.org; Mon, 17 Dec 2018 12:39:42 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45871) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gYwrf-00038d-OD for emacs-devel@gnu.org; Mon, 17 Dec 2018 12:39:36 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gYwrd-0004nV-F9 for emacs-devel@gnu.org; Mon, 17 Dec 2018 12:39:35 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41200) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gYwrY-0004ZW-8N; Mon, 17 Dec 2018 12:39:28 -0500 Original-Received: from [176.228.60.248] (port=2491 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gYwrW-0006yf-Lh; Mon, 17 Dec 2018 12:39:28 -0500 In-reply-to: (message from Robert Pluim on Mon, 17 Dec 2018 13:41:11 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231885 Archived-At: > From: Robert Pluim > Cc: emacs-devel@gnu.org, ari.roponen@gmail.com > Date: Mon, 17 Dec 2018 13:41:11 +0100 > > >> Aligning ftfont.c and ftcrfont.c is pretty easy. Did you want me to > >> try to unify xftfont.c in there as well? > > > > If that makes sense, i.e. if the commonality seems to justify that, > > then yes. > > > > I had a quick go at this. Iʼve not measured the memory difference, but > I can do if people thinks this refactor is worth it. Apart from the > unification of the three struct definitions, most of the patch is > mechanical changes. Thanks, this LGTM, and is a significant improvement, IMO. If no one objects in a few days, please push. P.S. Will this have any problems with the harfbuzz branch?