all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: 34256-done@debbugs.gnu.org
Subject: bug#34256: 27.0.50; Crash on draw_glyphs()
Date: Mon, 04 Feb 2019 19:50:50 +0200	[thread overview]
Message-ID: <837eefv3wl.fsf@gnu.org> (raw)
In-Reply-To: <CAFyQvY2YEmrBOMpFqgPj=KrpwT8fW_ssk8QfjW7D4U0K006gfA@mail.gmail.com> (message from Kaushal Modi on Mon, 4 Feb 2019 11:03:37 -0500)

> From: Kaushal Modi <kaushal.modi@gmail.com>
> Date: Mon, 4 Feb 2019 11:03:37 -0500
> Cc: 34256@debbugs.gnu.org
> 
> Thanks for the patch!
> 
> I couldn't apply the patch, so had to apply it manually.
> 
> But it works!

Thanks, I've now pushed it to the master branch.

> I am looking forward to understand in plain terms what this fix did. 

What happened was that while the display engine was redisplaying the
buffer, font-lock was called to fontify some part of the buffer, and
that activated Org mode (because the buffer displayed diffs of an Org
file, I presume?), and Org mode explicitly clears the image cache of
the frame for some reason I couldn't fathom.  So an inline image that
was ready to be displayed got removed and freed from under the feet of
the display engine, and when the time came to actually display it,
there was nothing to display...

The fix is to inhibit clearing of a frame's image cache until after
the frame has been updated by the display engine.

Thanks for helping me track this bug.





      reply	other threads:[~2019-02-04 17:50 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-30 14:30 bug#34256: 27.0.50; Crash on draw_glyphs() Kaushal Modi
2019-01-30 16:16 ` Eli Zaretskii
2019-01-30 16:35   ` Kaushal Modi
2019-01-30 16:51     ` Eli Zaretskii
2019-01-30 18:22       ` Kaushal Modi
2019-01-30 18:55         ` Eli Zaretskii
2019-01-30 20:54           ` Kaushal Modi
2019-01-31 14:02             ` Eli Zaretskii
2019-01-31 15:50               ` Kaushal Modi
2019-01-31 16:52                 ` Eli Zaretskii
2019-01-31 17:02                   ` Kaushal Modi
2019-01-31 17:05                     ` Kaushal Modi
2019-01-31 20:26                     ` Eli Zaretskii
2019-02-01  3:15                       ` Kaushal Modi
2019-02-01  3:25                         ` Kaushal Modi
2019-02-01  8:41                           ` Eli Zaretskii
2019-02-04 16:03                             ` Kaushal Modi
2019-02-04 17:50                               ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=837eefv3wl.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=34256-done@debbugs.gnu.org \
    --cc=kaushal.modi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.