From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH] Fixes to allow erc-dcc-get-filter to work properly
Date: Fri, 08 Feb 2019 09:59:48 +0200
Message-ID: <837eear9qj.fsf@gnu.org>
References: <CD36F2CB-49E3-4441-AEAF-DD6B62B1CF13.notmuch@neverland>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="183298"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: emacs-devel@gnu.org
To: Victor Orlikowski <vjo@duke.edu>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 08 09:00:33 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1gs15N-000laI-HJ
	for ged-emacs-devel@m.gmane.org; Fri, 08 Feb 2019 09:00:33 +0100
Original-Received: from localhost ([127.0.0.1]:52732 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1gs15M-00074i-F2
	for ged-emacs-devel@m.gmane.org; Fri, 08 Feb 2019 03:00:32 -0500
Original-Received: from eggs.gnu.org ([209.51.188.92]:57569)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1gs14m-00074c-KV
	for emacs-devel@gnu.org; Fri, 08 Feb 2019 02:59:57 -0500
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40750)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1gs14i-0007sE-P2; Fri, 08 Feb 2019 02:59:54 -0500
Original-Received: from [176.228.60.248] (port=3636 helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1gs14h-00041b-Rb; Fri, 08 Feb 2019 02:59:52 -0500
In-reply-to: <CD36F2CB-49E3-4441-AEAF-DD6B62B1CF13.notmuch@neverland> (message
	from Victor Orlikowski on Sun, 3 Feb 2019 17:47:16 +0000)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:233109

> From: Victor Orlikowski <vjo@duke.edu>
> Date: Sun, 3 Feb 2019 17:47:16 +0000
> 
> When using erc-dcc-get-filter with erc-dcc-verbose set to t, message
> errors prevent the DCC get from completing correctly.
> 
> The attached patch adds some additional error checking to
> erc-dcc-get-filter, and uses erc-dcc-file-name in place of
> buffer-file-name (which ends up being nil in this context, and
> causing the message errors).

Thanks.  Can you please elaborate on the problem, perhaps showing an
example of the behavior before and after your patch?  I don't think I
understand the issue with buffer-file-name (but then I don't use ERC).