all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Victor Orlikowski <vjo@duke.edu>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Fixes to allow erc-dcc-get-filter to work properly
Date: Fri, 08 Feb 2019 09:59:48 +0200	[thread overview]
Message-ID: <837eear9qj.fsf@gnu.org> (raw)
In-Reply-To: <CD36F2CB-49E3-4441-AEAF-DD6B62B1CF13.notmuch@neverland> (message from Victor Orlikowski on Sun, 3 Feb 2019 17:47:16 +0000)

> From: Victor Orlikowski <vjo@duke.edu>
> Date: Sun, 3 Feb 2019 17:47:16 +0000
> 
> When using erc-dcc-get-filter with erc-dcc-verbose set to t, message
> errors prevent the DCC get from completing correctly.
> 
> The attached patch adds some additional error checking to
> erc-dcc-get-filter, and uses erc-dcc-file-name in place of
> buffer-file-name (which ends up being nil in this context, and
> causing the message errors).

Thanks.  Can you please elaborate on the problem, perhaps showing an
example of the behavior before and after your patch?  I don't think I
understand the issue with buffer-file-name (but then I don't use ERC).



  reply	other threads:[~2019-02-08  7:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-03 17:47 [PATCH] Fixes to allow erc-dcc-get-filter to work properly Victor Orlikowski
2019-02-08  7:59 ` Eli Zaretskii [this message]
2019-02-08 22:00   ` Victor Orlikowski
2019-02-09  9:49     ` Eli Zaretskii
2019-02-10 16:07       ` Victor Orlikowski
2019-02-10 16:41         ` Eli Zaretskii
2019-02-10 19:02           ` Victor Orlikowski
2019-02-10 19:14 ` [PATCH] v2: " Victor Orlikowski
2019-02-15  8:18   ` Eli Zaretskii
2019-02-17 18:57     ` Victor Orlikowski
2019-02-17 19:32       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=837eear9qj.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=vjo@duke.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.