all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Łukasz Stelmach" <stlman@poczta.fm>
Cc: 34796@debbugs.gnu.org
Subject: bug#34796: [PATCH] * lisp/simple.el (delete-indentation): Join lines in a region
Date: Fri, 15 Mar 2019 10:13:59 +0200	[thread overview]
Message-ID: <837ed01rnc.fsf@gnu.org> (raw)
In-Reply-To: <20190309175634.23262-1-stlman@poczta.fm> (message from Łukasz Stelmach on Sat, 9 Mar 2019 18:56:34 +0100)

> From: Łukasz Stelmach <stlman@poczta.fm>
> Date: Sat,  9 Mar 2019 18:56:34 +0100
> Cc: Łukasz Stelmach <stlman@poczta.fm>
> 
> If a region is active, join all the lines it spans.

Thanks.

Please provide a ChangeLog-style commit log message for your proposed
changes, and also accompany them with suitable changes to NEWS and the
user manual.

> -(defun delete-indentation (&optional arg)
> +(defun delete-indentation (&optional arg beg end)
>    "Join this line to previous and fix up whitespace at join.
> -If there is a fill prefix, delete it from the beginning of this line.
> -With argument, join this line to following line."
> -  (interactive "*P")
> +If there is a fill prefix, delete it from the beginning of this
> +line.  With argument, join this line to following line. With a
> +region active, join lines in the region. If both argument and
> +region are set, the region is ignored."

Please leave 2 spaces between sentences in the doc string.

With those issues taken care of, I think this feature can be
installed.





  parent reply	other threads:[~2019-03-15  8:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-09 17:56 bug#34796: [PATCH] * lisp/simple.el (delete-indentation): Join lines in a region Łukasz Stelmach
     [not found] ` <handler.34796.B.155215436111455.ack@debbugs.gnu.org>
2019-03-10  7:14   ` Łukasz Stelmach
2019-03-15  8:13 ` Eli Zaretskii [this message]
2019-03-15 21:06   ` bug#34796: [PATCH] If the region is active, join all the lines it spans Łukasz Stelmach
2019-03-22  9:08     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=837ed01rnc.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=34796@debbugs.gnu.org \
    --cc=stlman@poczta.fm \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.