From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#35062: [PATCH v3 1/3] Remove redundant comparison Date: Mon, 15 Apr 2019 20:16:32 +0300 Message-ID: <837ebvi3yn.fsf@gnu.org> References: <1554071761.31929.0@yandex.ru> <20190407021331.948-1-Hi-Angel@yandex.ru> <1555347785.24195.0@yandex.ru> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="114941"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35062@debbugs.gnu.org, rms@gnu.org To: Konstantin Kharlamov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 15 19:17:20 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hG5EO-000TmY-5X for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Apr 2019 19:17:20 +0200 Original-Received: from localhost ([127.0.0.1]:53485 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hG5EN-0007W0-2M for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Apr 2019 13:17:19 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40172) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hG5E9-0007Ue-M9 for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2019 13:17:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hG5E8-0006el-SQ for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2019 13:17:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50035) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hG5E8-0006eT-MY for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2019 13:17:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hG5E8-0006mj-3k for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2019 13:17:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Apr 2019 17:17:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35062 X-GNU-PR-Package: emacs Original-Received: via spool by 35062-submit@debbugs.gnu.org id=B35062.155534862226070 (code B ref 35062); Mon, 15 Apr 2019 17:17:04 +0000 Original-Received: (at 35062) by debbugs.gnu.org; 15 Apr 2019 17:17:02 +0000 Original-Received: from localhost ([127.0.0.1]:35345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hG5E5-0006mH-Tg for submit@debbugs.gnu.org; Mon, 15 Apr 2019 13:17:02 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53980) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hG5E3-0006m2-BI for 35062@debbugs.gnu.org; Mon, 15 Apr 2019 13:17:00 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60248) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hG5Dy-0006RJ-1f; Mon, 15 Apr 2019 13:16:54 -0400 Original-Received: from [176.228.60.248] (port=1500 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hG5Dn-0004N4-75; Mon, 15 Apr 2019 13:16:44 -0400 In-reply-to: <1555347785.24195.0@yandex.ru> (message from Konstantin Kharlamov on Mon, 15 Apr 2019 20:03:05 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157670 Archived-At: > Date: Mon, 15 Apr 2019 20:03:05 +0300 > From: Konstantin Kharlamov > Cc: rms@gnu.org, 35062@debbugs.gnu.org > > > No, the log message was not the problem. Look at the code changes, > > they were the ones I modified. > > The line that I changed is exactly the same. What you did is cleaning > up the function even further, however that didn't touch my > modifications. Your modification is not strictly relevant to my patch. That's your perspective, but not mine. My perspective is that you changed one line, whereas I changed 3, and by that also changed the overall logic of the tests. > Okay, let's compare: > > 1. Doing extra commit: "git commit" > 2. Changing last commit "git commit --amend" > > You did 2, do you see how 1 has less symbols? No I didn't do 2. I just edited the sources and did 1. I never applied your patch.