From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Emacs build fails [MSYS2/MINGW64]
Date: Tue, 30 Apr 2019 18:45:19 +0300
Message-ID: <837ebbsdio.fsf@gnu.org>
References: <1443630449.1251981.1556465864402@mail.libero.it>
	<6790fa0c-6544-df50-b4f1-a77ca0daea1f@cs.ucla.edu>
	<1118604098.1569315.1556538785729@mail.libero.it>
	<d791a219-76ff-d0ac-3ef4-db40c25b6101@gmx.at> <83imuwual4.fsf@gnu.org>
	<60bbd1ea-e7dc-c056-5298-7d7ee95e0031@cs.ucla.edu>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="261689"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: emacs-devel@gnu.org
To: Paul Eggert <eggert@cs.ucla.edu>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 30 18:20:31 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hLVUd-0015vK-Ae
	for ged-emacs-devel@m.gmane.org; Tue, 30 Apr 2019 18:20:31 +0200
Original-Received: from localhost ([127.0.0.1]:49551 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hLVUc-0005EX-7W
	for ged-emacs-devel@m.gmane.org; Tue, 30 Apr 2019 12:20:30 -0400
Original-Received: from eggs.gnu.org ([209.51.188.92]:49804)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1hLUwh-0001Lv-5Z
	for emacs-devel@gnu.org; Tue, 30 Apr 2019 11:45:28 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49087)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1hLUwg-0003Er-IE; Tue, 30 Apr 2019 11:45:26 -0400
Original-Received: from [176.228.60.248] (port=1465 helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1hLUwf-0007Fk-Bf; Tue, 30 Apr 2019 11:45:25 -0400
In-reply-to: <60bbd1ea-e7dc-c056-5298-7d7ee95e0031@cs.ucla.edu> (message from
	Paul Eggert on Mon, 29 Apr 2019 12:38:02 -0700)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:236055
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/236055>

> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Mon, 29 Apr 2019 12:38:02 -0700
> Cc: angelo.g0@libero.it, emacs-devel@gnu.org
> 
> -#if __has_attribute (cold)
> +/* Avoid __attribute__ ((cold)) on MinGW; see thread starting at
> +   <https://lists.gnu.org/r/emacs-devel/2019-04/msg01152.html>. */
> +#if __has_attribute (cold) && !defined __MINGW32__

We defined __has_attribute_cold, so no need to use __has_attribute
here, right?