From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#35468: [PATCH] Refactor draw_glyph_string on X and w32 Date: Wed, 01 May 2019 20:38:17 +0300 Message-ID: <837ebaqdme.fsf@gnu.org> References: <877ebeor2d.fsf@gmail.com> <83tveit5ph.fsf@gnu.org> <87pnp5oqu1.fsf@gmail.com> <877ebcogg4.fsf@gmail.com> <83sgu0rsue.fsf@gnu.org> <20190430201129.GA73973@breton.holly.idiocy.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="393"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35468@debbugs.gnu.org, agrambot@gmail.com To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 01 19:39:17 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hLtCO-00187C-H6 for geb-bug-gnu-emacs@m.gmane.org; Wed, 01 May 2019 19:39:16 +0200 Original-Received: from localhost ([127.0.0.1]:37636 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLtCN-00063M-DU for geb-bug-gnu-emacs@m.gmane.org; Wed, 01 May 2019 13:39:15 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38855) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLtCC-00060m-1B for bug-gnu-emacs@gnu.org; Wed, 01 May 2019 13:39:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hLtCA-0006ck-8O for bug-gnu-emacs@gnu.org; Wed, 01 May 2019 13:39:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59520) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hLtC9-0006cN-Sa for bug-gnu-emacs@gnu.org; Wed, 01 May 2019 13:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hLtC9-0002a6-Oy for bug-gnu-emacs@gnu.org; Wed, 01 May 2019 13:39:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 01 May 2019 17:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35468 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35468-submit@debbugs.gnu.org id=B35468.15567323149885 (code B ref 35468); Wed, 01 May 2019 17:39:01 +0000 Original-Received: (at 35468) by debbugs.gnu.org; 1 May 2019 17:38:34 +0000 Original-Received: from localhost ([127.0.0.1]:44831 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLtBi-0002ZN-Bc for submit@debbugs.gnu.org; Wed, 01 May 2019 13:38:34 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52497) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLtBg-0002ZA-FR for 35468@debbugs.gnu.org; Wed, 01 May 2019 13:38:32 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:57072) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLtBb-00067x-7V; Wed, 01 May 2019 13:38:27 -0400 Original-Received: from [176.228.60.248] (port=1529 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hLtBV-0003zb-Ut; Wed, 01 May 2019 13:38:23 -0400 In-reply-to: <20190430201129.GA73973@breton.holly.idiocy.org> (message from Alan Third on Tue, 30 Apr 2019 21:11:29 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158589 Archived-At: > Date: Tue, 30 Apr 2019 21:11:29 +0100 > From: Alan Third > Cc: Alex Gramiak , 35468@debbugs.gnu.org > > > > if (s->hl == DRAW_MOUSE_FACE) > > > { > > > face = FACE_FROM_ID_OR_NULL (s->f, > > > MOUSE_HL_INFO (s->f)->mouse_face_face_id); > > > if (!face) > > > face = FACE_FROM_ID (s->f, MOUSE_FACE_ID); > > > } > > > else > > > face = s->face; > > > > I don't know why this is TRT, either. We could ask Alan to look into > > this, or we could simply remove that, as other terminals don't use > > box_line_width from the mouse face, they use s->face instead. > > A quick test doesn’t turn up any immediate issues with removing this, > but I’m unsure in what circumstances DRAW_MOUSE_FACE would be in use. E.g., when you hover the mouse pointer above the mouse-sensitive portions of the mode line.