From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Date: Wed, 08 May 2019 11:47:39 +0300 Message-ID: <837eb1ib84.fsf@gnu.org> References: <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> <87lfzlgvka.fsf@gmx.de> <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> <78A0704A-59E6-4D25-8FF3-8FD011942885@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="165780"; mail-complaints-to="usenet@blaine.gmane.org" Cc: michael.albinus@gmx.de, 35418@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 08 10:48:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hOIFI-000h2Q-4o for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 May 2019 10:48:12 +0200 Original-Received: from localhost ([127.0.0.1]:33317 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOIFH-0004f1-6L for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 May 2019 04:48:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40795) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOIF9-0004es-1w for bug-gnu-emacs@gnu.org; Wed, 08 May 2019 04:48:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hOIF8-0006gL-6s for bug-gnu-emacs@gnu.org; Wed, 08 May 2019 04:48:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46771) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hOIF8-0006gF-40 for bug-gnu-emacs@gnu.org; Wed, 08 May 2019 04:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hOIF8-0007g1-1J for bug-gnu-emacs@gnu.org; Wed, 08 May 2019 04:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 May 2019 08:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155730527829500 (code B ref 35418); Wed, 08 May 2019 08:48:01 +0000 Original-Received: (at 35418) by debbugs.gnu.org; 8 May 2019 08:47:58 +0000 Original-Received: from localhost ([127.0.0.1]:60315 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOIF3-0007fj-UW for submit@debbugs.gnu.org; Wed, 08 May 2019 04:47:58 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:54588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOIF2-0007fX-GO for 35418@debbugs.gnu.org; Wed, 08 May 2019 04:47:56 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:47509) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOIEx-0006Vp-4H; Wed, 08 May 2019 04:47:51 -0400 Original-Received: from [176.228.60.248] (port=4867 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hOIEw-0006K9-L3; Wed, 08 May 2019 04:47:50 -0400 In-reply-to: <78A0704A-59E6-4D25-8FF3-8FD011942885@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Wed, 8 May 2019 10:34:13 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158925 Archived-At: > From: Mattias Engdegård > Date: Wed, 8 May 2019 10:34:13 +0200 > Cc: Eli Zaretskii , 35418@debbugs.gnu.org > > + ;; Don't bother creating a notifier for non-file buffers > + ;; if there is a custom `revert-buffer-function'. > + ;; An exception is made for Dired, since that mode works > + ;; well with notifiers. > (when (and auto-revert-use-notify > - (not auto-revert-notify-watch-descriptor)) > + (not auto-revert-notify-watch-descriptor) > + (or buffer-file-name > + (eq major-mode 'dired-mode))) Is Dired the only exception from the rule? Or is there a more general indication that a non-file buffer may want to be automatically reverted? E.g., what about Info buffers? revert-buffer does work there. Thanks.